Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: No PodDisruptionBudget for minAvailable equal server's numbers. #1772

Merged
merged 5 commits into from
Oct 7, 2023
Merged

feat: No PodDisruptionBudget for minAvailable equal server's numbers. #1772

merged 5 commits into from
Oct 7, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Sep 12, 2023

No PodDisruptionBudget for single pod
fix: #1764

harshavardhana
harshavardhana previously approved these changes Sep 12, 2023
View reviewed changes
@jiuker jiuker changed the title fix: No PodDisruptionBudget for single pod feat: No PodDisruptionBudget for single pod Sep 12, 2023
@cniackz cniackz self-requested a review September 12, 2023 19:26
cniackz
cniackz previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would like @pjuarezd to take a look prior merging it.

@jiuker jiuker dismissed stale reviews from cniackz and harshavardhana via c9405c9 September 18, 2023 01:55
@jiuker jiuker changed the title feat: No PodDisruptionBudget for single pod feat: No PodDisruptionBudget for minAvailable equal server's numbers. Sep 18, 2023
@harshavardhana harshavardhana merged commit 52bd365 into minio:master Oct 7, 2023
24 checks passed
@feorlen
Copy link
Contributor

feorlen commented Oct 9, 2023 •
edited

Adding a note in preparation for next Operator release doc updates. Comment elsewhere from @jiuker:

PDB will not create for server are 1 or 2, because there are no half +1 for them

@djwfyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@pjuarezd pjuarezd pjuarezd approved these changes

@shtripat shtripat Awaiting requested review from shtripat

@cniackz cniackz Awaiting requested review from cniackz

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to set PodDisruptionBudget
6 participants
@jiuker @feorlen @harshavardhana @pjuarezd @cniackz @bh4t