Create buckets upon tenant creation or after tenant creation

[cniackz]

Fixes : #1783

Objective:

To be able to create a bucket after the tenant is created.

Reasoning:

We have customers who wants to create buckets once tenant is created by just changing GitOps Tenant Spec YAML. This will save them time as they will not need to create additional Jobs or containers to add buckets and all is needed is to change the tenant spec in their GitOps/ArgoCD flow.

Testing:

By doing this, we can keep creating as many buckets as needed after tenant is deployed. And we are protected against any failure because we have the code already in place to detect when bucket is created:

• File: operator/pkg/apis/minio.min.io/v2/helper.go

		}); err != nil {
			switch minio.ToErrorResponse(err).Code {
			case "BucketAlreadyOwnedByYou", "BucketAlreadyExists":
				klog.Infof(err.Error())
				continue

As a result we get in the logs:

I0919 20:21:59.241643   81813 helper.go:779] Your previous request to create the named bucket succeeded and you already own it.

Question is:

• If this is not approved, why we want to create bucket just upon tenant creation?: add bucket upon tenant creation #820

• If we can create buckets on the fly, should we do it? what is the advantage or disadvantage of not doing it?. Please let's discuss this internally for me to understand better the reasons behind 820 PR.

[shtripat]

lgtm

[jiuker]

lgtm. Should we mark this field as discarded? @cniackz

[cniackz]

@jiuker what do you mean by field as discarded?....
I merged this PR because it got approved by 3 people
And the change should be harmless
So no, let's no discard this changed but keep it and if it affects somehow, we can revert it.

[allanrogerr]

fixes #1346