Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: createBuckets simplify implementation #1840

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: createBuckets simplify implementation #1840

merged 3 commits into from
Oct 31, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Oct 31, 2023

  1. fix: createBuckets success will not log
  2. refactor createBuckets.

harshavardhana
harshavardhana previously approved these changes Oct 31, 2023
View reviewed changes
@jiuker jiuker requested a review from cniackz October 31, 2023 06:55
shtripat
shtripat previously approved these changes Oct 31, 2023
View reviewed changes
pkg/apis/minio.min.io/v2/helper.go Outdated Show resolved Hide resolved
@jiuker jiuker dismissed stale reviews from shtripat and harshavardhana via 0103d0b October 31, 2023 10:53
shtripat
shtripat approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana changed the title fix: createBuckets success will not log fix: createBuckets simplify implementation Oct 31, 2023
@harshavardhana harshavardhana merged commit a73ce13 into minio:master Oct 31, 2023
24 checks passed
@krishgu krishgu mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@shtripat shtripat shtripat approved these changes

@cniackz cniackz Awaiting requested review from cniackz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiuker @harshavardhana @shtripat