Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for admin ServerUpdate to update containers simultaneously #187

Merged
merged 1 commit into from Jul 24, 2020
Merged

Add support for admin ServerUpdate to update containers simultaneously #187

merged 1 commit into from Jul 24, 2020

Conversation

harshavardhana
Copy link
Member

No description provided.

@nitisht nitisht requested review from dvaldivia and nitisht and removed request for dvaldivia July 23, 2020 07:10
@harshavardhana
Copy link
Member Author

This PR testing would depend on the PR minio/minio#10107 here

pkg/controller/cluster/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/cluster/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/cluster/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/cluster/main-controller.go Outdated Show resolved Hide resolved
kerneltime
kerneltime previously approved these changes Jul 23, 2020
dvaldivia
dvaldivia previously approved these changes Jul 24, 2020
@harshavardhana
Copy link
Member Author

Tested all the changes are working as expected

diff --git a/examples/tenant.yaml b/examples/tenant.yaml
index 0abf379..254f440 100644
--- a/examples/tenant.yaml
+++ b/examples/tenant.yaml
@@ -42,7 +42,8 @@ spec:
       prometheus.io/port: "9000"
       prometheus.io/scrape: "true"
   ## Registry location and Tag to download MinIO Server image
-  image: minio/minio:RELEASE.2020-07-22T00-26-33Z
+  image: y4m4/minio:RELEASE.2020-07-21T01-08-20Z
+  #image: minio/minio:RELEASE.2020-07-22T00-26-33Z
   ## A ClusterIP Service will be created with the given name
   serviceName: minio-internal-service
   zones:
@@ -56,7 +57,8 @@ spec:
             - ReadWriteOnce
           resources:
             requests:
-              storage: 1Ti
+              storage: 20Gi
+          storageClassName: direct.csi.min.io
   ## Mount path where PV will be mounted inside container(s). Defaults to "/export".
   mountPath: /export
   ## Sub path inside Mount path where MinIO starts. Defaults to "".
diff --git a/minio-operator.yaml b/minio-operator.yaml
index 58617d6..7dd915c 100644
--- a/minio-operator.yaml
+++ b/minio-operator.yaml
@@ -276,7 +276,7 @@ spec:
         name: minio-operator
     spec:
       containers:
-        - image: minio/k8s-operator:3.0.0
-          imagePullPolicy: IfNotPresent
+        - image: y4m4/k8s-operator:test
+          imagePullPolicy: Always
           name: minio-operator
       serviceAccountName: minio-operator

Apply the following diff locally and then change the container image after deployment
with a second kubectl apply -f you can see the container restart and update first
before they do rolling upgrades.

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Tested

@nitisht nitisht merged commit 53ff4b7 into minio:master Jul 24, 2020
@harshavardhana harshavardhana deleted the add-upgrade branch July 24, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants