Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate service label and annotation absence #2095

Merged
merged 1 commit into from
May 1, 2024

Conversation

allanrogerr
Copy link
Contributor

@allanrogerr allanrogerr commented Apr 26, 2024

When the users delete labels or annotations from serviceMetadata, the operator should delete the corresponding label or annotation from the service. This is to maintain the expected and actual service definitions in sync.

Currently, if an entry is deleted from the serviceMetadata element, the corresponding label or annotation remains on the corresponding service.

This fixes #2038

See full tests here https://github.com/allanrogerr/public/wiki/operator%E2%80%902038

Test summary:

  1. Deploy an operator and tenant
  2. Add labels and annotations to .spec.serviceMetadata
  3. Observe the console and minio services match these tenant changes
  4. Validate that minio is still accessible from the Console UI and s3 API
  5. Remove labels and annotations to .spec.serviceMetadata
  6. Observe the console and minio services match these tenant changes
  7. Validate that minio is still accessible from the Console UI and s3 API

@allanrogerr
Copy link
Contributor Author

Fixes #2038

@allanrogerr allanrogerr marked this pull request as ready for review April 26, 2024 22:34
@pjuarezd pjuarezd merged commit f1c3de2 into minio:master May 1, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to delete console service labels
3 participants