Validate service label and annotation absence #2095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the users delete labels or annotations from
serviceMetadata
, the operator should delete the corresponding label or annotation from the service. This is to maintain the expected and actual service definitions in sync.Currently, if an entry is deleted from the serviceMetadata element, the corresponding label or annotation remains on the corresponding service.
This fixes #2038
See full tests here https://github.com/allanrogerr/public/wiki/operator%E2%80%902038
Test summary:
.spec.serviceMetadata
.spec.serviceMetadata