feat: Add support tenant update via image available to operator #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
changed the title
harshavardhana
requested changes
Aug 25, 2020
harshavardhana
requested changes
Aug 26, 2020
|
I made some more improvements
|
|
https://github.com/nitisht/minio-operator/pull/1 here is the PR @nitisht |
kerneltime
reviewed
Aug 27, 2020
kerneltime
reviewed
Aug 27, 2020
The update flow is - Operator has access to a new MinIO Docker Image. - Admin requests an update of a certain tenant using `kubectl apply`. - Operator identifies this request and fetches the minio binary and other relevant files to a local directory. - Operator makes minio admin api call with a URL of its own webhook server. - Tenant fetches the binary and other files extracted in previous step and updates itself. - Operator deletes all temporary files after successful update.
The update flow is - Operator has access to a new MinIO Docker Image. - Admin requests an update of a certain tenant using `kubectl apply`. - Operator identifies this request and fetches the minio binary and other relevant files to a local directory. - Operator makes minio admin api call with a URL of its own webhook server. - Tenant fetches the binary and other files extracted in previous step and updates itself. - Operator deletes all temporary files after successful update.
|
Works for all situations @nitisht |
dvaldivia
reviewed
Aug 27, 2020
| // Correct URL could not be obtained, not proceeding to update. | ||
| return fmt.Errorf("Unable to get canonical update URL, failed with %w", err) | ||
| return fmt.Errorf("Unable to get canonical update URL for Tenant '%s', failed with %w", name, err) |
There was a problem hiding this comment.
I'm seeing through all this error returns, I think maybe we should also update the status of the Tenant to indicate the Update failed for X reason
Please apply this with as |
harshavardhana
previously approved these changes
Aug 28, 2020
harshavardhana
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update flow is
kubectl apply.and other relevant files to a local directory.
server.
previous step and updates itself.