update status for tenant upon binary update failure #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
previously approved these changes
Aug 28, 2020
Signed-off-by: soulseen <zhuxiaoyang1996@gmail>
This PR also borrows the change from #260
kerneltime
approved these changes
Aug 31, 2020
dvaldivia
reviewed
Aug 31, 2020
| } | ||
|
|
||
| if us.CurrentVersion != us.UpdatedVersion { | ||
| klog.Infof("Tenant '%s' MinIO updated successfully from: %s, to: %s successfully", | ||
| name, us.CurrentVersion, us.UpdatedVersion) | ||
| } else { | ||
| klog.Infof("Tenant '%s' MinIO is already running the most recent version of %s", | ||
| msg := fmt.Sprintf("Tenant '%s' MinIO is already running the most recent version of %s", |
There was a problem hiding this comment.
but if we do this, we are never going back to ready state are we?
There was a problem hiding this comment.
@dvaldivia yes we are never ready if update failed.
There was a problem hiding this comment.
makes sense, but it's not an static status state, I think we can improve the status in the future to have status + message so we can provide details on why we reached a certain state
dvaldivia
approved these changes
Aug 31, 2020
| } | ||
|
|
||
| if us.CurrentVersion != us.UpdatedVersion { | ||
| klog.Infof("Tenant '%s' MinIO updated successfully from: %s, to: %s successfully", | ||
| name, us.CurrentVersion, us.UpdatedVersion) | ||
| } else { | ||
| klog.Infof("Tenant '%s' MinIO is already running the most recent version of %s", | ||
| msg := fmt.Sprintf("Tenant '%s' MinIO is already running the most recent version of %s", |
There was a problem hiding this comment.
makes sense, but it's not an static status state, I think we can improve the status in the future to have status + message so we can provide details on why we reached a certain state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also borrows the change from #260