Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go 1.16, Remove Statik and switch to Embed #516

Merged
merged 8 commits into from Mar 6, 2021

Conversation

dvaldivia
Copy link
Collaborator

Removes the dependency on statik, we still need to copy the resources around sadly, but now we use the native embed for embedding static files

Makefile Outdated Show resolved Hide resolved
resources/assets.go Show resolved Hide resolved
Copy link
Contributor

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & Tested

@nitisht nitisht merged commit 570a0a8 into minio:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants