Add anti-affinity to Tenants #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
requested review from
harshavardhana,
wlan0,
Praveenrajmani and
dvaldivia
harshavardhana
previously approved these changes
Mar 16, 2021
wlan0
reviewed
Mar 17, 2021
|
just one comment about the flag name. LGTM otherwise |
harshavardhana
requested changes
Mar 17, 2021
wlan0
previously approved these changes
Mar 17, 2021
|
LGTM |
dvaldivia
previously approved these changes
Mar 17, 2021
|
I think this is good, we should additionally document this for unsuspecting developer who are creating tenants on k8s clusters with one a few nodes that cannot satisfy the anti-affinity clause |
Good point yeah, that’ll be important too. Otherwise, they wouldn’t know why their deployment isn’t working. |
This PR adds a flag called --enable-host-sharing to the kubectl plugin. With this change, the plugin will add anti-affinity rules to the tenant by default. To disable this, set this flag to false.
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag called --enable-host-sharing to the
kubectl plugin.
With this change, the plugin will add anti-affinity
rules to the tenant by default. To disable this, set this flag
to false.