Only start API service on elected leader #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
harshavardhana,
Alevsk,
bexsoft and
kanagarajkm
Alevsk
previously approved these changes
Oct 15, 2021
harshavardhana
requested changes
Oct 15, 2021
harshavardhana
changed the title
harshavardhana
changed the title
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
dvaldivia
force-pushed
the
start-api-only-by-leader
branch
from
e058602
to
1780042
Compare
harshavardhana
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so only the leader starts the API, this is due to the fact that we also do the operator CSR when we start the API, and if two pods are trying to generate a CSR at the same time, maybe none of them will get it
Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com