ldap: Include server name is tls config #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the server name to the TLS config in the LDAP client connection object. When upgrading a connection using STARTTLS it seems to be required to verify the server certificate. Additionally, stop using deprecated function in the go-ldap library and switch to supported ones.
|
Marking this as draft until some testing with tls enabled openldap. |
|
Is this still needed @donatello ? |
|
No I was waiting on some user input on this but they never came back. I don't think it's needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the server name to the TLS config in the LDAP client connection object. When upgrading a connection using STARTTLS it seems to be required to verify the server certificate.
Additionally, stop using deprecated function in the go-ldap library and switch to supported ones.