Add two new APIs to split the upgrade process #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrepareAndCheckBinary() downloads the binary to a location different to the final destination, it also applies the patch and does the checksum if configured. CommitBinary() will move the staging binary to the final location. This is useful when you want to upgrade many machines at the same time but you want to load the new binary only when the download is successful in all of those machines. In that case, CommitBinary() will less likely to fail. Apply() will keep its current behavior and will call PrepareAndCheckBinary() and CommitBinary()
harshavardhana
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrepareAndCheckBinary() downloads the binary to a location different
to the final destination, it also applies the patch and does the
checksum if configured.
CommitBinary() will move the staging binary to the final location.
This is useful when you want to upgrade many machines at the same time
but you want to load the new binary only when the download is successful
in all of those machines. In that case, CommitBinary() will less likely
to fail.
Apply() will keep its current behavior and will call
PrepareAndCheckBinary() and CommitBinary()