Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: OpenRTB request parsing #75

Merged
merged 1 commit into from
Oct 17, 2022
Merged

examples: OpenRTB request parsing #75

merged 1 commit into from
Oct 17, 2022

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Oct 16, 2022

Here is an example extracted from a real highly loaded OpenRTB parser.
It's a good sample how to work with inline structures and arrays.

I'm not sure that this is the most efficient way of use so please tell me if something can be optimized. For example reuse of the ParsedJson on the benchmark increases usage of memory.
I don't know how this can be explained. Maybe you have a guess why.

@klauspost klauspost merged commit d7877ad into minio:master Oct 17, 2022
@klauspost
Copy link
Collaborator

@stokito The iterators and stuff seems to be stack allocated, so they are cheap.

The only impactful improvement would be to avoid all the strings, since they will of course need allocs, but that would be a quality of life reduction.

@stokito stokito deleted the examples_openrtb branch October 17, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants