Add DecryptBuffer for small payloads #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `DecryptBuffer` which will allow to decrypt smaller buffers without too much overhead. There is fallback for the legacy DARE1 which doesn't benefit too much from this, but that can be added later if needed.
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Oct 21, 2020
`decryptObjectInfo` is a significant bottleneck when listing objects. Reduce the allocations for a significant speedup. Requires: minio/sio#40 `go.mod` replace term until upstream is available. ``` λ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta Benchmark_decryptObjectInfo-32 24260928 808656 -96.67% benchmark old MB/s new MB/s speedup Benchmark_decryptObjectInfo-32 0.04 1.24 31.00x benchmark old allocs new allocs delta Benchmark_decryptObjectInfo-32 75112 48996 -34.77% benchmark old bytes new bytes delta Benchmark_decryptObjectInfo-32 287694772 4228076 -98.53% ```
1 task
aead
reviewed
Oct 21, 2020
aead
reviewed
Oct 22, 2020
aead
approved these changes
Oct 22, 2020
harshavardhana
approved these changes
Oct 22, 2020
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Oct 29, 2020
`decryptObjectInfo` is a significant bottleneck when listing objects. Reduce the allocations for a significant speedup. minio/sio#40 ``` λ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta Benchmark_decryptObjectInfo-32 24260928 808656 -96.67% benchmark old MB/s new MB/s speedup Benchmark_decryptObjectInfo-32 0.04 1.24 31.00x benchmark old allocs new allocs delta Benchmark_decryptObjectInfo-32 75112 48996 -34.77% benchmark old bytes new bytes delta Benchmark_decryptObjectInfo-32 287694772 4228076 -98.53% ```
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Oct 31, 2020
`decryptObjectInfo` is a significant bottleneck when listing objects. Reduce the allocations for a significant speedup. minio/sio#40 ``` λ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta Benchmark_decryptObjectInfo-32 24260928 808656 -96.67% benchmark old MB/s new MB/s speedup Benchmark_decryptObjectInfo-32 0.04 1.24 31.00x benchmark old allocs new allocs delta Benchmark_decryptObjectInfo-32 75112 48996 -34.77% benchmark old bytes new bytes delta Benchmark_decryptObjectInfo-32 287694772 4228076 -98.53% ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
DecryptBufferwhich will allow to decrypt smaller buffers without too much overhead.There is fallback for the legacy DARE1 which doesn't benefit too much from this, but that can be added later if needed.