Add host file input #298
Merged
Add host file input #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow file as host input for benchmark targets or clients.
Example `warp-hosts.txt`:
```
127.0.0.1:{9001...9004}
127.1.2.3
giga.abc.com
```
Debug printing loaded hosts:
```
λ warp stat --host=file:warp-hosts.txt
HOSTS: [127.0.0.1:9001 127.0.0.1:9002 127.0.0.1:9003 127.0.0.1:9004 127.1.2.3 giga.abc.com]
λ warp stat --warp-client=file:warp-hosts.txt
hosts [127.0.0.1:9001 127.0.0.1:9002 127.0.0.1:9003 127.0.0.1:9004 127.1.2.3 giga.abc.com]
```
Slightly more generic version of minio#297 (and avoids another flag)
harshavardhana
approved these changes
Jan 26, 2024
klauspost
force-pushed
the
file-hosts-alternative
branch
from
431673b
to
f367b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow file as host input for benchmark targets or clients.
Example
warp-hosts.txt:Debug printing loaded hosts:
Slightly more generic version of #297 (and avoids another flag)