New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #42 Eclipse Che add-on #43

Merged

coolbrg merged 1 commit into minishift:master from sunix:che-addon

Oct 18, 2017

sunix commented Oct 12, 2017 •

edited by coolbrg

Fix #42

Early stage of a minishift addon, feedbacks are welcome.

Contributor

coolbrg commented Oct 12, 2017

@sunix , Thanks for the PR. Could you also add README of it?

kameshsampath reviewed

View reviewed changes

add-ons/che/che.addon Outdated

+              # Required-Vars:
+              echo NOTE: To delete this addon, execute:
+              echo oc delete project/mini-che

Contributor

kameshsampath Oct 13, 2017

lets not create or delete project, we just create tempaltes and leave

kameshsampath reviewed

View reviewed changes

add-ons/che/che.addon Outdated


		echo Creating mini-che project
		oc new-project mini-che --description="Eclipse Che on minishift" --as=developer

Contributor

kameshsampath Oct 13, 2017

lets not create or delete project, we just create templates and leave

kameshsampath reviewed

View reviewed changes

add-ons/che/che.addon Outdated

+              echo   minishift console
+              echo -
+              echo Then you should be able the open the Che dashboard here:
+              echo   http://che-mini-che.#{ip}.nip.io

Contributor

kameshsampath Oct 13, 2017

we can avoid line #11 to # 26 and just do
oc apply -f templates/che-single-user.json -n openshift

kameshsampath reviewed

View reviewed changes

add-ons/che/mini-che-template.yml Outdated

+                    che.predefined.stacks.reload_on_start: 'false'
+                    docker-connector: openshift
+                    enable-workspaces-autostart: 'false'
+                    hostname-http: 'che-mini-che.${DOMAIN}'

Contributor

kameshsampath Oct 13, 2017

fixing domain ip will make che deployable only one project

kameshsampath reviewed

View reviewed changes

add-ons/che/mini-che-template.yml Outdated

+                    enable-workspaces-autostart: 'false'
+                    hostname-http: 'che-mini-che.${DOMAIN}'
+                    keycloak-disabled: 'true'
+                    keycloak-github-endpoint: 'https://sso.openshift.io/auth/realms/fabric8/broker/github/token'

Contributor

kameshsampath Oct 13, 2017

avoid it for minishift as its not applicable

kameshsampath reviewed

View reviewed changes

add-ons/che/mini-che-template.yml Outdated

+                    hostname-http: 'che-mini-che.${DOMAIN}'
+                    keycloak-disabled: 'true'
+                    keycloak-github-endpoint: 'https://sso.openshift.io/auth/realms/fabric8/broker/github/token'
+                    keycloak-oso-endpoint: 'https://sso.openshift.io/auth/realms/fabric8/broker/openshift-v3/token'

Contributor

kameshsampath Oct 13, 2017

avoid it for minishift as its not applicable

kameshsampath reviewed

View reviewed changes

add-ons/che/mini-che-template.yml Outdated

+                      spec:
+                        containers:
+                          - env:
+                              - name: CHE_DOCKER_IP_EXTERNAL

Contributor

kameshsampath Oct 13, 2017 •

edited

this we can do via Template parameters like

{
   "name": "CHE_DOCKER_IP_EXTERNAL",
   "value": "${CHE_OPENSHIFT_PROJECT}-${DOMAIN_NAME}"
}

kameshsampath reviewed

View reviewed changes

add-ons/che/mini-che-template.yml Outdated

+                                  configMapKeyRef:
+                                    key: che-workspace-auto-snapshot
+                                    name: che
+                            image: 'docker.io/eclipse/che-server:nightly'

Contributor

kameshsampath Oct 13, 2017 •

edited

this should be from Image streams rather than particular image to handle image and tags better

Contributor

kameshsampath commented Oct 13, 2017

@sunix
awesome!! but got some comments and added review to the files as well.

I would love to have a ImageStream added with list of Che Server images and DeploymentConfig using it.

I have a similar version here https://github.com/kameshsampath/minishift-che-addon, wondering we could merge them together.

kameshsampath mentioned this pull request

Fix #42 minishift/minishift#1561

Closed

kameshsampath added a commit to kameshsampath/minishift-addons that referenced this pull request


          Fixes minishift#42 by enhancing minishift#43

2c20ae2

kameshsampath mentioned this pull request

Closed

Member

LalatenduMohanty commented Oct 13, 2017

@sunix Closing this PR as #44 supersedes this PR in the of what you and Kamesh discussed in the #minishift channel.

LalatenduMohanty closed this

LalatenduMohanty reopened this

Member

LalatenduMohanty commented Oct 13, 2017

Re-opening the PR as per @sunix's request.

sunix force-pushed the che-addon branch from cd15f18 to 42a44c1 Compare

October 16, 2017 08:07

Contributor

kameshsampath commented Oct 16, 2017

@sunix - do you see any comments on this ticket, right now am working on a small pod that can be deployed along with Che- which sanitises the stack (like what replace_stacks.sh) does .

coolbrg suggested changes

View reviewed changes

Contributor

coolbrg left a comment

@sunix , Could you add README ?

Author

sunix commented Oct 17, 2017

@budhrg Yes, currently merging #44 with this one, testing and will provide readme once everything works fine

sunix force-pushed the che-addon branch from 42a44c1 to 1aa3b5c Compare

October 17, 2017 14:38

coolbrg reviewed

View reviewed changes

add-ons/che/che.addon Outdated

+              echo [CHE] Switching to mini-che...
+              oc project mini-che
+              echo [CHE] Deploying Che on minishift (image docker.io/eclipse/che-server:nightly)

Contributor

coolbrg Oct 17, 2017

Just a reminder to remove nightly tag. Probably use exact version.

Contributor

kameshsampath Oct 17, 2017

@sunix - i have one query around project creation here. say if the user deletes the project then he might not have this instance so he has to create via Add To Project or reapply the addon( am not sure this is possible). WDYT?

coolbrg reviewed

View reviewed changes

add-ons/che/che.addon Outdated

+              echo -
+              echo You can watch in the OpenShift console via:
+              echo   minishift console
+              echo -

Contributor

coolbrg Oct 17, 2017

This is coming as it is . You don't need - here.

sunix force-pushed the che-addon branch from 1aa3b5c to 0d9bbff Compare

October 17, 2017 15:22

gbraad reviewed

View reviewed changes

add-ons/che/README.md Outdated


		This addon provides an easy way to install Eclipse Che on MiniShift.

		Eclipse Che provides a complete Cloud IDE.

Member

gbraad Oct 17, 2017

"cloud IDE"

gbraad reviewed

View reviewed changes

add-ons/che/README.md Outdated

+              # Eclipse Che Addon
+              This addon create Eclipse Che templates, image streams and a project running Che in Minishift. In short this helps in setting up Eclipse Che
+              on minishift inline with https://www.eclipse.org/che/docs/setup/openshift/index.html#deploy-che-on-minishift[Deploy Che on Minishift]

Member

gbraad Oct 17, 2017

[Deploy Che on Minishift](https://www.eclipse.org/che/docs/setup/openshift/index.html#deploy-che-on-minishift)

Contributor

coolbrg Oct 17, 2017

Yes :) this syntax is of Ascii doc :)

gbraad changed the title ~~Eclipse Che addon~~ Issue #42 Eclipse Che addon

sunix force-pushed the che-addon branch 2 times, most recently from f2f8213 to 4571b7e Compare

October 17, 2017 16:08

gbraad approved these changes

View reviewed changes

Contributor

l0rd commented Oct 17, 2017

@sunix it looks like you are using the default Che stacks. If that's the case it will always take a couple of minutes to start a workspace on minishift (the time for the ssh agent to timeout). That would be a poor UX and something that should be addressed. If there is no time to do it in this PR I would recommend to mention the problem in the README.md and open an issue to track that.

Contributor

kameshsampath commented Oct 18, 2017

@l0rd - am right now working on a small utility that can be deployed as side car(pod) or can be used as cli for Che which can do the refresh stack + some more things I have planned. will share the same with you and @sunix once i have basic version working.

Member

gbraad commented Oct 18, 2017 •

edited

@l0rd we can actually use anyuid, so what else would prevent us from SSH to properly start?

$ minishift addons enable anyuid
$ minishift addons enable che

This results in the terminal of the Blank workspace showing:

user@che-ws-trncd29y1gxh90pi-3982296087-s77rd:/projects$ ps ax
...
   10 ?        S      0:00 sudo /usr/sbin/sshd -D
   12 ?        S      0:00 /usr/sbin/sshd -D
...

and for the CentOS-based workspace:

user@che-ws-trncd29y1gxh90pi-3982296087-s77rd:/projects$ ps ax
...
  421 ?        S      0:00 sudo -E /usr/sbin/sshd -D
  422 ?        S      0:00 /usr/sbin/sshd -D
...

dgolovin mentioned this pull request

Add Eclipse Che installer redhat-developer-tooling/developer-platform-install#911

Closed

5 tasks

coolbrg reviewed

View reviewed changes

add-ons/che/README.md Outdated

+              # Eclipse Che Addon
+              This addon create Eclipse Che templates, image streams and a project running Che in Minishift. In short this helps in setting up Eclipse Che
+              on minishift inline with [Deploy Che on Minishift](https://www.eclipse.org/che/docs/setup/openshift/index.html#deploy-che-on-minishift)

Contributor

coolbrg Oct 18, 2017

on Minishift inline with.

Minishift as brand name and minishift for CLI purpose.

Contributor

coolbrg commented Oct 18, 2017

Got this error while starting with Java + Mysql stack. Yesterday too, got similar error. After restarting the workspace, it is not starting properly.

Member

gbraad commented Oct 18, 2017

@budhrg I do not get the same error... for me it is a simple:

Could not start workspace wksp-pdlq. Reason: Start of environment 'default' failed. Error: null

Happens for the Java and the .NET Core images,

Contributor

kameshsampath commented Oct 18, 2017

@budhrg and @gbraad - since che is a upstream project the default docker images can't be used directly in OpenShift as they all run as root. to mitigate that as part of the installation we have a step to replace the stacks --> https://www.eclipse.org/che/docs/setup/openshift/index.html#deploy-che-on-minishift, the addon currently does not do that step. For now the workaround is to run the replace_stacks step, having said that am working on to get a sidecar deployed along with che which will take care of this ( still testing it)

@l0rd - please add/correct if I have missed anything.

Member

gbraad commented Oct 18, 2017

@kameshsampath I am running with anyuid and therefore I can use root inside the containers. For example, the CentOS container allows me to use sudo yum install golang glide and I can use it to compile Minishift.

Member

gbraad commented Oct 18, 2017

hferentschik changed the title ~~Issue #42 Eclipse Che addon~~ Issue #42 Eclipse Che add-on

Member

hferentschik commented Oct 18, 2017

I have a feeling this add-on is at the wrong place. Given that the Che add-on is essential to us, I'd argue that it should be added in the main Minishift repo as a default add-on. This will also allow us to add integration test and it will make things easier for productization.

ATM, there is nothing in place to productize this community driven add-on repository.

Member

hferentschik commented Oct 18, 2017 •

edited

I take my comment #43 (comment) back. It does not make sense. ;-) Given the current state of things this is probably the best space.

It would be nice if the README would add some information on what works and what not. For example workspace persistence is an issue with Minishift, right?

gbraad reviewed

View reviewed changes

add-ons/che/README.md Outdated

               Clone this repository onto your local machine and then install the add-on via:
                   $ minishift addons install <path_to_directory_containing_this_readme>
                   $ minishift addons enable che
-              `enable` will setup eclipse che at next minishift start
+              `enable` will setup eclipse che at next Minishift start

Member

gbraad Oct 18, 2017 •

edited

I think this should be:

enable will setup Eclipse Che at next minishift start

or:

enable will setup Eclipse Che when you start Minishift the next time.

Contributor

coolbrg Oct 18, 2017

Yes, for all CLI operation, it should minishift.

Author

sunix Oct 18, 2017

ok i make that fix

l0rd reviewed

View reviewed changes

add-ons/che/README.md Outdated

               <a name="install-add-on"></a>
               ### Install add-on
+              Che default stacks require root privilege to run sshd. Without root privilege, workspaces will take more time to timeout and start.
+              One workaround would be to enable the `anyuid` addon. Another way would be to [replace the existing stacks](#replace-stacks) with the ones without the `sshd` agent.

Contributor

l0rd Oct 18, 2017

Does anyuid work? Someone has tested if sshd get started? Because we explicitely start the container as unprivileged in the OpenShiftConnector.

Contributor

kameshsampath Oct 18, 2017

@sunix - we also can add one more template parameter called MAVEN_MIRROR_URL , we have just added made the che stack images to use MAVEN_MIRRORS like how other openshift images does

Author

sunix Oct 18, 2017

@l0rd I've tested with ayuid and startup is faster for sure

Author

sunix Oct 18, 2017

@kameshsampath not sure to get this, but maybe this should be part of another PR ?

Contributor

coolbrg Oct 18, 2017

@l0rd , is this related to it #43 (comment)

Contributor

l0rd Oct 18, 2017

ok thanks @budhrg and @sunix


          Issue minishift#42 Eclipse Che addon

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>

sunix force-pushed the che-addon branch from 3a29629 to 0984944 Compare

October 18, 2017 12:53

coolbrg approved these changes

View reviewed changes

coolbrg merged commit 0984944 into minishift:master

sunix mentioned this pull request

Package Che as a minishift addon redhat-developer/rh-che#353

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment