Addon for Ansible Service Broker #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowen-rh
previously requested changes
Dec 7, 2017
| @@ -0,0 +1,70 @@ | |||
| Ansible Service Broker Addon | |||
| ====================== | |||
There was a problem hiding this comment.
This is a suggestion which you can feel free to ignore, but I find that it's easier to both maintain and understand headings which use #.
| $ export MINISHIFT_ENABLE_EXPERIMENTAL=y | ||
| ``` | ||
|
|
||
| Start Minishift with the `--service-catalog` flag |
There was a problem hiding this comment.
Please add a colon to the end of this sentence.
| |`BROKER_AUTH`|Broker Authentication|`{"basicAuthSecret":{"namespace":"ansible-service-broker","name":"asb-auth-secret"}}`| | ||
| |`ENABLE_BASIC_AUTH`|Enable Basic Authentication within the Broker|`true`| | ||
|
|
||
| Variables can be specified by adding `--addon-env <key=value>` when the addon is being invoked (`minishift start` or `minishift addons apply`) |
There was a problem hiding this comment.
(either by `minishift start` or `minishift addons apply`).Also, please note the period ending the sentence. :)
| Ansible Service Broker Addon | ||
| ====================== | ||
|
|
||
| This addon installs the [Ansible Service Broker](https://github.com/openshift/ansible-service-broker) |
There was a problem hiding this comment.
We refer to add-ons with hyphenation within the documentation -- please do so throughout this document as well. :)
|
|
||
| Minishift/CDK must be deployed with the Service Catalog enabled | ||
|
|
||
| The Service Catalog can be deployed by adding the `--service-catalog` when starting Minishift. The ability to pass extra flags during startup can be enabled by setting the _MINISHIFT_ENABLE_EXPERIMENTAL_ environmental variable as follows: |
There was a problem hiding this comment.
the `--service-catalog` flag|
|
||
| * To apply the addon to a running instance of Minishift, execute the following command: | ||
|
|
||
| $ minishift addons apply ansible-service-broker |
There was a problem hiding this comment.
I'd like to see one more new line here to separate the command example from the following sentence.
|
|
||
| ## Remove the Addon | ||
|
|
||
| To remove all of the deployed components, execute the following command |
There was a problem hiding this comment.
Please add a colon to the end of this sentence.
|
|
||
| ## Uninstall the addon | ||
|
|
||
| To uninstall the addon, execute the following command |
There was a problem hiding this comment.
Please add a colon to the end of this sentence.
|
@robin-owen updated based on feedback |
LalatenduMohanty
requested changes
Dec 18, 2017
|
|
||
| ``` | ||
| $ minishift start --service-catalog | ||
| ``` |
There was a problem hiding this comment.
@sabre1041 I think OpenShift v3.7.0 is advisable for this add-on as 3.6.0 had different implementation for oc cluster up and it did not work always. WDYT?
There was a problem hiding this comment.
@sabre1041 tested on v 3.7.0 and it worked for me. Going ahead and merging this, please send another PR if you want to set minimum version to v3.7.0 https://docs.openshift.org/latest/minishift/using/addons.html#addon-openshift-version-semantics
$ minishift start --openshift-version v3.7.0 --service-catalog
-- Starting profile 'minishift'
-- Checking if requested hypervisor 'kvm' is supported on this platform ... OK
-- Checking if KVM driver is installed ...
Driver is available at /usr/local/bin/docker-machine-driver-kvm ...
Checking driver binary is executable ... OK
-- Checking if Libvirt is installed ... OK
-- Checking if Libvirt default network is present ... OK
-- Checking if Libvirt default network is active ... OK
-- Checking the ISO URL ... OK
-- Starting local OpenShift cluster using 'kvm' hypervisor ...
-- Minishift VM will be configured with ...
Memory: 2 GB
vCPUs : 2
Disk size: 20 GB
-- Starting Minishift VM ...................... OK
-- Checking for IP address ... OK
-- Checking if external host is reachable from the Minishift VM ...
Pinging 8.8.8.8 ... OK
-- Checking HTTP connectivity from the VM ...
Retrieving http://minishift.io/index.html ... OK
-- Checking if persistent storage volume is mounted ... OK
-- Checking available disk space ... 0% used OK
-- Downloading OpenShift binary 'oc' version 'v3.7.0'
38.51 MiB / 38.51 MiB [=========================================================================================================================================] 100.00% 0s-- Downloading OpenShift v3.7.0 checksums ... OK
-- OpenShift cluster will be configured with ...
Version: v3.7.0
-- Checking `oc` support for startup flags ...
host-config-dir ... OK
host-data-dir ... OK
host-pv-dir ... OK
host-volumes-dir ... OK
version ... OK
routing-suffix ... OK
service-catalog ... OK
Starting OpenShift using openshift/origin:v3.7.0 ...
Pulling image openshift/origin:v3.7.0
Pulled 1/4 layers, 26% complete
Pulled 1/4 layers, 42% complete
Pulled 1/4 layers, 57% complete
Pulled 1/4 layers, 72% complete
Pulled 2/4 layers, 76% complete
Pulled 3/4 layers, 88% complete
Pulled 3/4 layers, 99% complete
Pulled 4/4 layers, 100% complete
Extracting
Image pull complete
OpenShift server started.
The server is accessible via web console at:
https://192.168.42.113:8443
You are logged in as:
User: developer
Password: <any value>
To login as administrator:
oc login -u system:admin
[lmohanty@LalatenduM-laptop minishift-addons]$ minishift addon apply ansible-service-broker
-- Applying addon 'ansible-service-broker':.......
Ansible Service Broker Deployed
LalatenduMohanty
approved these changes
Dec 18, 2017
|
|
||
| ``` | ||
| $ minishift start --service-catalog | ||
| ``` |
There was a problem hiding this comment.
@sabre1041 tested on v 3.7.0 and it worked for me. Going ahead and merging this, please send another PR if you want to set minimum version to v3.7.0 https://docs.openshift.org/latest/minishift/using/addons.html#addon-openshift-version-semantics
$ minishift start --openshift-version v3.7.0 --service-catalog
-- Starting profile 'minishift'
-- Checking if requested hypervisor 'kvm' is supported on this platform ... OK
-- Checking if KVM driver is installed ...
Driver is available at /usr/local/bin/docker-machine-driver-kvm ...
Checking driver binary is executable ... OK
-- Checking if Libvirt is installed ... OK
-- Checking if Libvirt default network is present ... OK
-- Checking if Libvirt default network is active ... OK
-- Checking the ISO URL ... OK
-- Starting local OpenShift cluster using 'kvm' hypervisor ...
-- Minishift VM will be configured with ...
Memory: 2 GB
vCPUs : 2
Disk size: 20 GB
-- Starting Minishift VM ...................... OK
-- Checking for IP address ... OK
-- Checking if external host is reachable from the Minishift VM ...
Pinging 8.8.8.8 ... OK
-- Checking HTTP connectivity from the VM ...
Retrieving http://minishift.io/index.html ... OK
-- Checking if persistent storage volume is mounted ... OK
-- Checking available disk space ... 0% used OK
-- Downloading OpenShift binary 'oc' version 'v3.7.0'
38.51 MiB / 38.51 MiB [=========================================================================================================================================] 100.00% 0s-- Downloading OpenShift v3.7.0 checksums ... OK
-- OpenShift cluster will be configured with ...
Version: v3.7.0
-- Checking `oc` support for startup flags ...
host-config-dir ... OK
host-data-dir ... OK
host-pv-dir ... OK
host-volumes-dir ... OK
version ... OK
routing-suffix ... OK
service-catalog ... OK
Starting OpenShift using openshift/origin:v3.7.0 ...
Pulling image openshift/origin:v3.7.0
Pulled 1/4 layers, 26% complete
Pulled 1/4 layers, 42% complete
Pulled 1/4 layers, 57% complete
Pulled 1/4 layers, 72% complete
Pulled 2/4 layers, 76% complete
Pulled 3/4 layers, 88% complete
Pulled 3/4 layers, 99% complete
Pulled 4/4 layers, 100% complete
Extracting
Image pull complete
OpenShift server started.
The server is accessible via web console at:
https://192.168.42.113:8443
You are logged in as:
User: developer
Password: <any value>
To login as administrator:
oc login -u system:admin
[lmohanty@LalatenduM-laptop minishift-addons]$ minishift addon apply ansible-service-broker
-- Applying addon 'ansible-service-broker':.......
Ansible Service Broker Deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addon for deploying the Ansible Service Broker