Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the latest Strimzi images #71

Merged
merged 1 commit into from Jan 19, 2018
Merged

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Jan 16, 2018

Strimzi is the new kid on the block - Barnabas was renamed, and the 0.1.0 release is used from Strimzi

@matzew
Copy link
Contributor Author

matzew commented Jan 16, 2018

@jpechane @ppatierno

@matzew
Copy link
Contributor Author

matzew commented Jan 16, 2018

part of https://issues.jboss.org/browse/DBZ-545

(will send more/different PRs)

@jpechane
Copy link
Contributor

@matzew Great work, thanks! Tested and it works flawlessly.

@matzew
Copy link
Contributor Author

matzew commented Jan 19, 2018

cool - anything preventing this from being merged ? 🙃

@gbraad
Copy link
Member

gbraad commented Jan 19, 2018

eh... Test results... ? @jpechane thanks for the feedback, but usually we also test it once. although at the we have all been busy with a release. if someone else can chime in, it would certainly speed this up.

gbraad
gbraad previously requested changes Jan 19, 2018
Copy link
Member

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No README updates needed?

@jpechane
Copy link
Contributor

jpechane commented Jan 19, 2018

@gbraad The readme was already there - this is just an update, see https://github.com/minishift/minishift-addons/blob/master/add-ons/debezium/README.md
And BTW as I wrote above - I tested it and it works as before

@gbraad
Copy link
Member

gbraad commented Jan 19, 2018

@jpechane I jus noticed...

We have been busy with a release, so attention wasn't on the addons.

@gbraad gbraad dismissed their stale review January 19, 2018 06:03

Update to current version

@gbraad gbraad merged commit 0d8299b into minishift:master Jan 19, 2018
@matzew
Copy link
Contributor Author

matzew commented Jan 19, 2018

Thanks @gbraad !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants