Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minikube ISO name does not show in the iso-url usage #1512

Closed
LalatenduMohanty opened this issue Oct 7, 2017 · 4 comments
Closed

Minikube ISO name does not show in the iso-url usage #1512

LalatenduMohanty opened this issue Oct 7, 2017 · 4 comments

Comments

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Oct 7, 2017

Currently on b2d and CentOS is shown in the usage and the documentation does not have information about minikube ISO [1].

$ minishift start --help | grep iso-url
      --iso-url string                  Location of the minishift ISO. Can be an URL, file URI or one of the following short names: [b2d centos]. (default "b2d")

[1] https://docs.openshift.org/latest/minishift/using/managing-minishift.html#choosing-iso-image

@gbraad
Copy link
Member

gbraad commented Oct 7, 2017

At the moment I think this is done on purpose... however, I think some of this also needs to be behind a feature toggle. We do not have a real 'location' to download the image from with our changes. I suggest to track the progress in a general task (verify feature parity: hostfolders, ip assignment, etc) and based on this decide if we can make this option available.

@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented Oct 8, 2017

@gbraad I understand your concerns but unless we do not expose the minikube ISO name in the usage I do not it will get any proper testing. I would suggest that we expose the short name and mention in the documentation [1] that the ISO is newly added to Minishift and should be considered experimental.
@minishift/minishift-dev comments?

[1] https://docs.openshift.org/latest/minishift/using/managing-minishift.html#choosing-iso-image

P:S: I have updated the original description about missing documentation.

@LalatenduMohanty LalatenduMohanty self-assigned this Oct 8, 2017
LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Oct 8, 2017
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Oct 9, 2017
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@gbraad
Copy link
Member

gbraad commented Oct 9, 2017

But when EnableExperimental is enabled I would say, as we have not performed any rigorous testing by ourselves.

LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Oct 9, 2017
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Oct 9, 2017
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty added a commit to LalatenduMohanty/minishift that referenced this issue Oct 9, 2017
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@coolbrg
Copy link
Contributor

coolbrg commented Oct 9, 2017

Resolved via #1514

@coolbrg coolbrg closed this as completed Oct 9, 2017
anjannath pushed a commit to anjannath/minishift that referenced this issue Nov 6, 2017
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants