Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and configure the Nvidia daemon set #4371

Merged
merged 6 commits into from
May 21, 2024
Merged

Conversation

BrianEllwood
Copy link
Contributor

@BrianEllwood BrianEllwood commented May 21, 2024

Pull Request Objective

To put into code the changes needed to setup nvidia daemon set

The purpose is to creare the nvidia-device-plugin via yaml rather than installing via helm which proved not to work.

#4120

Note: Static analysis has been overridden as the issues flagged in the development cluster are historic and not arising from the changes made in this PR.

@BrianEllwood BrianEllwood requested a review from a team as a code owner May 21, 2024 14:44
Copy link
Contributor

github-actions bot commented May 21, 2024

Terraform Component 🧱: aws-analytical-platform-development-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @AntFMoJ, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_static_analysis

Copy link
Contributor

github-actions bot commented May 21, 2024

Terraform Component 🧱: aws-analytical-platform-development-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @AntFMoJ, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_plan

Copy link
Member

@jacobwoffenden jacobwoffenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit b6d7210 into main May 21, 2024
16 checks passed
@jacobwoffenden jacobwoffenden deleted the add_deamon_helm branch May 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants