Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Regression - ELB no longer optional when it should be #56

Closed
mattmb opened this issue Mar 26, 2015 · 2 comments · Fixed by #65
Closed

Regression - ELB no longer optional when it should be #56

mattmb opened this issue Mar 26, 2015 · 2 comments · Fixed by #65
Assignees
@lukaszraczylo

Comments

@mattmb
Copy link
Contributor

mattmb commented Mar 26, 2015

I created a regression here:
https://github.com/ministryofjustice/bootstrap-cfn/blob/master/bootstrap_cfn/config.py#L84

This blows up if you have no ELB
@ashb
Copy link
Contributor

ashb commented Mar 26, 2015

Ahhh the main function that isn't tested \o/

@ashb ashb changed the title ELB no longer optional Regression - ELB no longer optional when it should be Mar 26, 2015
@mattmb
Copy link
Contributor Author

mattmb commented Mar 26, 2015

Yep, let's fix that too!

@ashb ashb added the ready label Mar 26, 2015
@lukaszraczylo lukaszraczylo self-assigned this Apr 8, 2015
@lukaszraczylo lukaszraczylo mentioned this issue Apr 8, 2015
Closed
@ashb ashb added in progress and removed ready labels Apr 8, 2015
@lukaszraczylo lukaszraczylo mentioned this issue Apr 8, 2015
Merged
@ashb ashb closed this as completed in #65 Apr 9, 2015
ashb added a commit that referenced this issue Apr 9, 2015
@ashb
Merge pull request #65 from ministryofjustice/issue/56-elb-no-longer-…
ef86a54 
…optional

 Added fix and test for missing ELB definition, closing #56
@ashb ashb removed the in progress label Apr 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lukaszraczylo lukaszraczylo

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ashb @lukaszraczylo @mattmb