This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Boto has built-in support for loading multiple named accounts, use it. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
force-pushed
the
use-boto-config
branch
from
e31fe4e
to
dc57d6e
Compare
ashb
changed the title
|
I need to rebase this now. (and I have done) |
ashb
force-pushed
the
use-boto-config
branch
2 times, most recently
from
577cce2
to
4a14fb5
Compare
ashb
changed the title
| profile_name=instance.aws_profile_name | ||
| ) | ||
| return conn | ||
| except NoAuthHandlerFound: |
There was a problem hiding this comment.
Rather than printing an error can you add an error class to errors.py and raise that with a message
|
Otherwise LGTM 👍 What shall we do about get_config? re the change here and in #45 Maybe we should rewrite it as get_aws_config, get_cf_config, get_project_config etc. PR that first, then rebase our branches? What seems like the least pain? |
|
@ashb Can you update the description to describe the intentions of this PR, what it might affect, and so on? |
| print "[ERROR] No AWS credentials" | ||
| print "Create an ~/.aws/credentials file by following this layout:\n\n" + \ | ||
| " http://boto.readthedocs.org/en/latest/boto_config_tut.html#credentials" | ||
| sys.exit(1) |
There was a problem hiding this comment.
Can we print errors to STDERR, not STDOUT?
|
Changes Unknown when pulling 23a9a84 on use-boto-config into * on master*. |
|
LGTM 👍 |
I haven’t added a specific task for it as we don’t do this very often. For instance `fab —set aws_region=eu-central-1 … cfn_create`
|
And final rebase so it merges cleanly. |
sevenmachines
pushed a commit
that referenced
this pull request
Jun 22, 2015
By passing tags while creating our cloudformation stack we can propagate these tags to our created resources, enabling easy separation of environments for billing purposes (closes #12)
sevenmachines
pushed a commit
that referenced
this pull request
Jun 23, 2015
By passing tags while creating our cloudformation stack we can propagate these tags to our created resources, enabling easy separation of environments for billing purposes (closes #12)
sevenmachines
pushed a commit
that referenced
this pull request
Jun 23, 2015
By passing tags while creating our cloudformation stack we can propagate these tags to our created resources, enabling easy separation of environments for billing purposes (closes #12)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1. This has two benefits:
This will cause everyone to fail with 'you don't have credentials' properly - I'll add something to the readme showing the new config format