Add CF config to salt pillar. #45
Conversation
| @@ -93,7 +93,7 @@ def get_config(): | |||
|
|
|||
| cfn_config = ConfigParser(project_config.config, get_stack_name()) | |||
| cfn = Cloudformation(aws_config) | |||
| return aws_config, cfn, cfn_config | |||
| return aws_config, cfn, cfn_config, project_config | |||
There was a problem hiding this comment.
Hmmmm this is fast going beyond the point of readability/maintainability.
We need to come up with a better solution to this.
|
Can you update the example config files and README please |
| 'cloudformation.sls'), | ||
| local_path=tfile_path, | ||
| use_sudo=True) | ||
| os.unlink(tfile_path) |
There was a problem hiding this comment.
Do we really have to create a temporary file to do this? Can we pass a StringIO object instead?
local_path may alternately be a file-like object, such as the result of open('path') or a StringIO instance.
There was a problem hiding this comment.
ooo, that would be nicer, will give it a try.
|
@stuartornum shouldn't need to change the example config. Good shout on the README. I need to update the CHANGELOG too. |
|
The example yaml's have no reference to salt - so I don't know (without going through the code) what the salt structure should look like |
mattmb
force-pushed
the
feature/salt-pillar
branch
from
661e834
to
4f3575c
Compare
This uploads the stack config to cloudformtaion.sls in the salt pillar dir. This way it can be included in the pillar in the deploy repositories and referenced in the salt templates.
mattmb
force-pushed
the
feature/salt-pillar
branch
2 times, most recently
from
7089437
to
4f55d77
Compare
mattmb
force-pushed
the
feature/salt-pillar
branch
from
4f55d77
to
bde1683
Compare
Add CF config to salt pillar.
This uploads the stack config to cloudformtaion.sls in the salt pillar dir. This way it can be included in the pillar in the deploy repositories and referenced in the salt templates.