This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Rename S3 bucket output to be consistent #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create cloudformation things we can create Outputs that represent them, which then get turned into grains, meaning that we can do lookups on randomly named resources. The buckets that are created have 2 things, a name, and a policy. The output for the S3 bucket currently is named like it references the policy, but actually it references the name. This change makes it more coherent with the form '<bucket_id>BucketName'.
|
Changes Unknown when pulling 45d0f79 on rename_s3_bucket_output_to_be_consistent into * on master*. |
|
Changes Unknown when pulling 6be9648 on rename_s3_bucket_output_to_be_consistent into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create cloudformation things we can create Outputs that represent them,
which then get turned into grains, meaning that we can do lookups on randomly
named resources. The buckets that are created have 2 things, a name, and a policy.
The output for the S3 bucket currently is named like it references the policy,
but actually it references the name. This change makes it more coherent with the
form '<bucket_id>BucketName'.