Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Issue#56: elb no longer optional #63

Closed
wants to merge 1 commit into from

Conversation

lukaszraczylo
Copy link
Contributor

Added fix and test for missing ELB definition as per issue#56

@coveralls
Copy link

Coverage Status

Coverage increased (+3.83%) to 53.26% when pulling 337ff5a on issue-56-elb-no-longer-optional into e4e41a2 on master.

@mattmb
Copy link
Contributor

mattmb commented Apr 8, 2015

LGTM 👍

Just need to remove that extra commit that's somehow crept in :-)

This directory caches those eggs to prevent repeated downloads.

However, it is safe to delete this directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I'm guessing you didn't mean to include this ;-)

@lukaszraczylo lukaszraczylo force-pushed the issue-56-elb-no-longer-optional branch from 337ff5a to 4ea19d1 Compare April 8, 2015 17:12
@lukaszraczylo
Copy link
Contributor Author

Removed 4d0a5d8 from branch "issue-56-elb-no-longer-optional"

@coveralls
Copy link

Coverage Status

Coverage increased (+3.83%) to 53.26% when pulling 4ea19d1 on issue-56-elb-no-longer-optional into e4e41a2 on master.

@lukaszraczylo
Copy link
Contributor Author

Please ignore - opened new pull requested with cherry picked commit as it was impossible to remove mentioned commit. New PR: #64

@ashb ashb removed the in progress label Apr 8, 2015
@lukaszraczylo lukaszraczylo deleted the issue-56-elb-no-longer-optional branch April 8, 2015 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants