Stubbed PingJsonView to fix deploys #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with current and imminent infra changes
This reverts commit 74a8f3a.
Circle exits on first failure before while
sldblog
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Replace ping response with a stub for compatibility with current deploys, as discussed, and future infra work.
Replace custom JsonResponse with native Django.
As a temporary workaround recommended by Cloud Platform, try multiple docker pushes to workaround DSD registry timeouts.
Any other changes that would benefit highlighting?
This duplicates PR 628, but shortens the branch name so DSD docker registry accepts the image.
Amended docstring to cover clarifying comment on PR 628.