Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(727b) Move personal details #163

Merged
merged 1 commit into from
Aug 31, 2023
Merged

(727b) Move personal details #163

merged 1 commit into from
Aug 31, 2023

Conversation

yndajas
Copy link
Contributor

@yndajas yndajas commented Aug 31, 2023

Context

We discussed this in a dev/design catchup - it makes more sense for the personal details to be closer to the page-specific content

Changes in this PR

  • Move the personal details banner lower down

Screenshots of UI changes

Before

image

After

image

Release checklist

Release process documentation

As part of our continuous deployment strategy we must ensure that this work is
ready to be released once merged.

Pre-merge

  • There are changes required to the Accredited Programmes API for this change to work...
    • ... and they have been released to production already

Post-merge

  • This adds, extends or meaningfully modifies a feature...
  • This makes new expectations of the API...
    • ... and I have notified the API developer(s) of changes to the contract tests (Pact), or the API is already compliant
  • Manually approve release to preprod
  • Manually approve release to prod

Per design feedback, it makes more sense for this to go below the
primary navigation, since this is more page/section-specific content
@yndajas
Copy link
Contributor Author

yndajas commented Aug 31, 2023

Copy link
Contributor

@bell-pa bell-pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jick63 jick63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yndajas yndajas merged commit ab8a4cd into main Aug 31, 2023
6 checks passed
@yndajas yndajas deleted the move-personal-details branch August 31, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants