-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump stylelint, stylelint-config-gds and stylelint-order #927
Bump stylelint, stylelint-config-gds and stylelint-order #927
Conversation
6b22e9c
to
f77a3c6
Compare
Bumps [stylelint](https://github.com/stylelint/stylelint), [stylelint-config-gds](https://github.com/alphagov/stylelint-config-gds) and [stylelint-order](https://github.com/hudochenkov/stylelint-order). These dependencies needed to be updated together. Updates `stylelint` from 13.13.1 to 14.6.1 - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@13.13.1...14.6.1) Updates `stylelint-config-gds` from 0.1.0 to 0.2.0 - [Release notes](https://github.com/alphagov/stylelint-config-gds/releases) - [Changelog](https://github.com/alphagov/stylelint-config-gds/blob/main/CHANGELOG.md) - [Commits](alphagov/stylelint-config-gds@0.1.0...0.2.0) Updates `stylelint-order` from 4.1.0 to 5.0.0 - [Release notes](https://github.com/hudochenkov/stylelint-order/releases) - [Changelog](https://github.com/hudochenkov/stylelint-order/blob/master/CHANGELOG.md) - [Commits](hudochenkov/stylelint-order@4.1.0...5.0.0) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development update-type: version-update:semver-major - dependency-name: stylelint-config-gds dependency-type: direct:development update-type: version-update:semver-minor - dependency-name: stylelint-order dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
f77a3c6
to
159f6d8
Compare
There are no problems running stylelint locally, but when run via docker, we get an error telling us that the extends value (which should be stylelint-config-gds/scss) in the stylelintrc.yml file is undefined |
stylelint-config-gds includes postcss-scss, this expects postcss as peer depdendency, by default, other dependencies use the wrong version. Needed to install as dependency so that the correct version is available. More info here: stylelint-scss/stylelint-config-standard-scss#5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Nit: possible to tidy commit history by removing 'For testing if issue is with...'
stylelint-config-gds includes postcss-scss, this expects postcss as peer depdendency, by default, other dependencies use the wrong version. Needed to install as dependency so that the correct version is available. More info here: stylelint-scss/stylelint-config-standard-scss#5
…gds-and-stylelint-order-14.6.1' of https://github.com/ministryofjustice/laa-court-data-ui into dependabot/npm_and_yarn/stylelint-and-stylelint-config-gds-and-stylelint-order-14.6.1
tried to hard reset to head and do the changes again but I think because of our commit policy, it adds it in as subsequent commits instead of removing the history |
Bumps stylelint, stylelint-config-gds and stylelint-order. These dependencies needed to be updated together.
Updates
stylelint
from 13.13.1 to 14.6.1Release notes
Sourced from stylelint's releases.
... (truncated)
Changelog
Sourced from stylelint's changelog.
... (truncated)
Commits
2a9cd77
14.6.10013adf
Prepare 14.6.199ec404
Update CHANGELOG.md2e3d1f6
Fix TypeError error "Cannot destructure property..." in custom-property-patte...c86e3ac
Bump eslint-plugin-jest from 26.1.1 to 26.1.2 (#5980)bf1cb71
Bump lint-staged from 12.3.6 to 12.3.7 (#5979)950d226
Bump debug from 4.3.3 to 4.3.4 (#5978)6140487
Bump np from 7.6.0 to 7.6.1 (#5977)d2b166b
Update CHANGELOG.md53470a0
Fix false positives for SVG elements in selector-type-case (#5973)Updates
stylelint-config-gds
from 0.1.0 to 0.2.0Changelog
Sourced from stylelint-config-gds's changelog.
Commits
d8938b7
Merge pull request #24 from alphagov/stylelint-14f88fae0
Bump version to 0.2.00a2afcf
Update stylelint.io URLs47d4c6e
Disable declaration-block-no-redundant-longhand-propertiesc72670d
Update URLs of stylelint-scss rulesda94ba3
Disable/tweak newly problematic rules10c941f
Resolve multiple inheritance challenges82b6e07
Remove rules already defined in stylelint-config-recommended-scssfd1f376
Remove rules already defined in stylelint-config-standard-scss102762c
Extend stylelint-config-standard-scss instead of using stylelint-scss plugin ...Updates
stylelint-order
from 4.1.0 to 5.0.0Release notes
Sourced from stylelint-order's releases.
Changelog
Sourced from stylelint-order's changelog.
Commits
46a1adf
5.0.0cf60f75
Prepare 5.0.05a2a9d4
Capitalize Stylelint nameb004e65
Merge pull request #150 from hudochenkov/stylelint-v1494c8847
Remove debugging commandsacd5c0f
Use latest npm in all Node versions8337b7e
Add debugging commands957a4ce
Rebuild package-lock from scratch in attempt to fix CI9169c66
Use latest PostCSScec0a74
Use stylelint released versionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)