Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylelint, stylelint-config-gds and stylelint-order #927

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 29, 2022

Bumps stylelint, stylelint-config-gds and stylelint-order. These dependencies needed to be updated together.
Updates stylelint from 13.13.1 to 14.6.1

Release notes

Sourced from stylelint's releases.

14.6.1

  • Fixed: custom-property-pattern TypeError for "Cannot destructure property..." (#5982).
  • Fixed: selector-type-case false positives for SVG elements (#5973).
  • Fixed: unit-no-unknown false positives for large/small/dynamic viewport units (#5970).

14.6.0

  • Added: declaration-property-max-values rule (#5920).
  • Fixed: *-no-important column position (#5957).
  • Fixed: custom-property-pattern false positives for interpolation in property name (#5949).
  • Fixed: font-family-name-quotes column position (#5955).
  • Fixed: selector-pseudo-*-no-unknown false positives and negatives (#5959).
  • Fixed: selector-pseudo-class-no-unknown false positives and negatives (#5956).

14.5.3

  • Fixed: *-list invalid option warnings for strings (#5934).

14.5.2

  • Fixed: clarity of invalid option warning message for objects (#5923).
  • Fixed: *-list false negatives for invalid options (#5924).
  • Fixed: custom-property-pattern false positives for interpolation inside var() (#5925).
  • Fixed: declaration-property-value-*-list column position (#5926).

14.5.1

  • Fixed: function-no-unknown ENOENT and TypeErrors (#5916).
  • Fixed: function-no-unknown false positives for interpolation (#5914).

14.5.0

  • Added: ignoreFunctions: [] to function-no-unknown (#5901).

14.4.0

  • Added: function-no-unknown rule (#5865).
  • Added: font-family-name-quotes autofix (#5806).
  • Fixed: throwing more informative error when all input files are ignored (#5709).
  • Fixed: custom-property-pattern false negatives for custom properties within var() (#5867).
  • Fixed: no-descending-specificity parseError for double-slash comments within selector lists (#5891).
  • Fixed: selector-pseudo-element-colon-notation false positives for escaped colons (#5879).

14.3.0

  • Added: support for meta.url to rules and plugins (#5845).
  • Added: hyperlinks for rules to terminal output (#5835).
  • Added: hyperlinks for plugins to terminal output (#5859).
  • Added: ignore: ["rules"] / ["at-rules"] to block-opening-brace-*-after (#5830).
  • Added: ignoreSelectors: [] to property-case (#5822).
  • Added: ignoreFunctions: [] to unit-allowed-list (#5857).
  • Added: camelCaseSvgKeywords to value-keyword-case - use this option if you want legacy camel case SVG keywords like currentColor (#5849).
  • Fixed: font-family-no-missing-generic-family-keyword false positives for revert and revert-layer (#5852).
  • Fixed: no-descending-specificity false positives for the ::-moz-focus-inner pseudo-element (#5831).
  • Fixed: value-keyword-case false negatives for SVG keywords like currentcolor (#5849).

14.2.0

... (truncated)

Changelog

Sourced from stylelint's changelog.

14.6.1

  • Fixed: custom-property-pattern TypeError for "Cannot destructure property..." (#5982).
  • Fixed: selector-type-case false positives for SVG elements (#5973).
  • Fixed: unit-no-unknown false positives for large/small/dynamic viewport units (#5970).

14.6.0

  • Added: declaration-property-max-values rule (#5920).
  • Fixed: *-no-important column position (#5957).
  • Fixed: custom-property-pattern false positives for interpolation in property name (#5949).
  • Fixed: font-family-name-quotes column position (#5955).
  • Fixed: selector-pseudo-*-no-unknown false positives and negatives (#5959).
  • Fixed: selector-pseudo-class-no-unknown false positives and negatives (#5956).

14.5.3

  • Fixed: *-list invalid option warnings for strings (#5934).

14.5.2

  • Fixed: clarity of invalid option warning message for objects (#5923).
  • Fixed: *-list false negatives for invalid options (#5924).
  • Fixed: custom-property-pattern false positives for interpolation inside var() (#5925).
  • Fixed: declaration-property-value-*-list column position (#5926).

14.5.1

  • Fixed: function-no-unknown ENOENT and TypeErrors (#5916).
  • Fixed: function-no-unknown false positives for interpolation (#5914).

14.5.0

  • Added: ignoreFunctions: [] to function-no-unknown (#5901).

14.4.0

  • Added: function-no-unknown rule (#5865).
  • Added: font-family-name-quotes autofix (#5806).
  • Fixed: throwing more informative error when all input files are ignored (#5709).
  • Fixed: custom-property-pattern false negatives for custom properties within var() (#5867).
  • Fixed: no-descending-specificity parseError for double-slash comments within selector lists (#5891).
  • Fixed: selector-pseudo-element-colon-notation false positives for escaped colons (#5879).

14.3.0

  • Added: support for meta.url to rules and plugins (#5845).
  • Added: hyperlinks for rules to terminal output (#5835).
  • Added: hyperlinks for plugins to terminal output (#5859).
  • Added: ignore: ["rules"] / ["at-rules"] to block-opening-brace-*-after (#5830).

... (truncated)

Commits

Updates stylelint-config-gds from 0.1.0 to 0.2.0

Changelog

Sourced from stylelint-config-gds's changelog.

0.2.0

  • Utilise stylelint-config-standard-scss as base rules for SCSS
  • Upgrade to Stylelint 14
Commits
  • d8938b7 Merge pull request #24 from alphagov/stylelint-14
  • f88fae0 Bump version to 0.2.0
  • 0a2afcf Update stylelint.io URLs
  • 47d4c6e Disable declaration-block-no-redundant-longhand-properties
  • c72670d Update URLs of stylelint-scss rules
  • da94ba3 Disable/tweak newly problematic rules
  • 10c941f Resolve multiple inheritance challenges
  • 82b6e07 Remove rules already defined in stylelint-config-recommended-scss
  • fd1f376 Remove rules already defined in stylelint-config-standard-scss
  • 102762c Extend stylelint-config-standard-scss instead of using stylelint-scss plugin ...
  • Additional commits viewable in compare view

Updates stylelint-order from 4.1.0 to 5.0.0

Release notes

Sourced from stylelint-order's releases.

5.0.0

  • Breaking change: Dropped Node.js 8 support. Node.js 12 or greater is now required.
  • Breaking change: Dropped support for Stylelint 13 and earlier.
  • Added support for Stylelint 14.
Changelog

Sourced from stylelint-order's changelog.

5.0.0

  • Breaking change: Dropped Node.js 8 support. Node.js 12 or greater is now required.
  • Breaking change: Dropped support for Stylelint 13 and earlier.
  • Added support for Stylelint 14.
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner March 29, 2022 02:07
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 29, 2022
@dependabot dependabot bot requested a review from naseberry March 29, 2022 02:07
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/stylelint-and-stylelint-config-gds-and-stylelint-order-14.6.1 branch 7 times, most recently from 6b22e9c to f77a3c6 Compare April 5, 2022 10:56
Bumps [stylelint](https://github.com/stylelint/stylelint), [stylelint-config-gds](https://github.com/alphagov/stylelint-config-gds) and [stylelint-order](https://github.com/hudochenkov/stylelint-order). These dependencies needed to be updated together.

Updates `stylelint` from 13.13.1 to 14.6.1
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@13.13.1...14.6.1)

Updates `stylelint-config-gds` from 0.1.0 to 0.2.0
- [Release notes](https://github.com/alphagov/stylelint-config-gds/releases)
- [Changelog](https://github.com/alphagov/stylelint-config-gds/blob/main/CHANGELOG.md)
- [Commits](alphagov/stylelint-config-gds@0.1.0...0.2.0)

Updates `stylelint-order` from 4.1.0 to 5.0.0
- [Release notes](https://github.com/hudochenkov/stylelint-order/releases)
- [Changelog](https://github.com/hudochenkov/stylelint-order/blob/master/CHANGELOG.md)
- [Commits](hudochenkov/stylelint-order@4.1.0...5.0.0)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: stylelint-config-gds
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: stylelint-order
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/stylelint-and-stylelint-config-gds-and-stylelint-order-14.6.1 branch from f77a3c6 to 159f6d8 Compare April 5, 2022 11:15
@ivanELEC
Copy link
Contributor

ivanELEC commented Apr 7, 2022

There are no problems running stylelint locally, but when run via docker, we get an error telling us that the extends value (which should be stylelint-config-gds/scss) in the stylelintrc.yml file is undefined

stylelint-config-gds includes postcss-scss, this expects postcss as peer
depdendency, by default, other dependencies use the wrong version. Needed
to install as dependency so that the correct version is available. More
info here:
stylelint-scss/stylelint-config-standard-scss#5
Copy link
Contributor

@naseberry naseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nit: possible to tidy commit history by removing 'For testing if issue is with...'

stylelint-config-gds includes postcss-scss, this expects postcss as peer
depdendency, by default, other dependencies use the wrong version. Needed
to install as dependency so that the correct version is available. More
info here:
stylelint-scss/stylelint-config-standard-scss#5
…gds-and-stylelint-order-14.6.1' of https://github.com/ministryofjustice/laa-court-data-ui into dependabot/npm_and_yarn/stylelint-and-stylelint-config-gds-and-stylelint-order-14.6.1
@ivanELEC
Copy link
Contributor

ivanELEC commented Apr 7, 2022

👍

Nit: possible to tidy commit history by removing 'For testing if issue is with...'

tried to hard reset to head and do the changes again but I think because of our commit policy, it adds it in as subsequent commits instead of removing the history

@ivanELEC ivanELEC merged commit ac72e96 into master Apr 7, 2022
@ivanELEC ivanELEC deleted the dependabot/npm_and_yarn/stylelint-and-stylelint-config-gds-and-stylelint-order-14.6.1 branch April 7, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants