Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Remove unused config #128

Merged
merged 1 commit into from
Jan 31, 2024
Merged

🔥 Remove unused config #128

merged 1 commit into from
Jan 31, 2024

Conversation

connormaglynn
Copy link
Contributor

@connormaglynn connormaglynn commented Jan 31, 2024 •
edited
Loading

👀 Purpose

  • In preparation of refactoring the application environment
  • Remove unused config so refactoring is easier

♻️ What's changed

  • Removed unused config from config files

📝 Notes

  • All of the application access these environment variables directly

@github-actions GitHub Actions
Copy link
Contributor

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 3 0 0.82s
✅ PYTHON flake8 3 0 0.44s
✅ PYTHON isort 3 3 0 0.18s
❌ PYTHON pylint 3 2 5.3s
✅ REPOSITORY gitleaks yes no 0.49s
❌ REPOSITORY trivy yes 1 6.72s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

tamsinforbes
tamsinforbes approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connormaglynn connormaglynn merged commit b5488ec into main Jan 31, 2024
3 of 4 checks passed
@connormaglynn connormaglynn deleted the refactor-config branch January 31, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamsinforbes tamsinforbes tamsinforbes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
⚙️ Operations Engineering
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connormaglynn @tamsinforbes