Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Replace all references of landing page PoC #71

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Conversation

jasonBirchall
Copy link
Member

Overview

👀 Purpose

The renaming is part of our efforts to align the application's name with our current operations and objectives, specifically focusing on our integration with GitHub. This change will help maintain consistency and clarity in our tooling and documentation.

♻️ What's changed

  • All instances of the old name operations-engineering-landing-page-poc have been updated to the new name operations-engineering-join-github.

  • The change affects various files across the application, including configuration files, documentation, and any scripts where the old name was referenced.

  • I have ensured that the renaming does not affect the functionality and performance of the application.

📝 Notes

  • Please review the changes for accuracy and completeness.
  • Check for any missed references or potential issues that might arise from this renaming.
  • Suggestions for further improvement or any concerns are highly welcomed.

Copy link
Contributor

github-actions bot commented Jan 12, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ DOCKERFILE hadolint 1 0 0.08s
✅ PYTHON black 25 3 0 0.93s
❌ PYTHON flake8 25 12 0.54s
✅ PYTHON isort 25 13 0 0.24s
❌ PYTHON pylint 25 18 4.12s
✅ REPOSITORY gitleaks yes no 0.31s
❌ REPOSITORY trivy yes 1 5.46s
✅ YAML prettier 1 0 0 0.43s
✅ YAML yamllint 1 0 0.25s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos otherwise LGTM

Dockerfile Outdated Show resolved Hide resolved
join_github_app/templates/components/base.html Outdated Show resolved Hide resolved
join_github_app/templates/components/base.html Outdated Show resolved Hide resolved
jasonBirchall and others added 4 commits January 12, 2024 11:54
Co-authored-by: tam <32667518+tamsinforbes@users.noreply.github.com>
Co-authored-by: tam <32667518+tamsinforbes@users.noreply.github.com>
Co-authored-by: tam <32667518+tamsinforbes@users.noreply.github.com>
@jasonBirchall jasonBirchall merged commit e347633 into main Jan 12, 2024
3 of 4 checks passed
@jasonBirchall jasonBirchall deleted the rename-app branch January 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants