✨ Improve GitHub Access Flow for Justice Users #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions outlined here: https://code.visualstudio.com/docs/languages/html#_formatting
* main: Add HTML_HTMLHINT to the list of linters 🎨 Format the html using js-beutify (default vscode) 🚸 Disable the option for a digital user to select ap 🔥 Remove ability for an digital user to access ap org ✅ Test the select organisation digital user logic 🔥 Remove unwanted print statement 🧑💻 Add digital justice domain logic and pass that downstream
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
jasonBirchall
changed the title
PepperMoJ
previously approved these changes
Jan 16, 2024
PepperMoJ
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 Purpose
@justice.gov.ukemail address an option to join one of two GitHub organisations via an Azure AD auth0 application.♻️ What's changed
✨ Extend Conditional Logic for Justice Emails: Enhanced the conditional statements in our logic to include handling for @justice.gov.uk email addresses, ensuring their access flow is correctly managed.
🎨 User Flow Error Handling: Improved error messages and handling mechanisms throughout the user flow, ensuring users are adequately informed in case of issues or discrepancies.
✨ Instructions for Justice.gov.uk Users: Added clear, user-friendly instructions on the new justice-user.html template for @justice.gov.uk users, guiding them through the Azure AD authentication process.
📝 Notes