Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEGA-1254 Embed fixes #96

Merged
merged 2 commits into from
Aug 2, 2022
Merged

VEGA-1254 Embed fixes #96

merged 2 commits into from
Aug 2, 2022

Conversation

hawx
Copy link
Contributor

@hawx hawx commented Aug 1, 2022

No description provided.

@hawx hawx self-assigned this Aug 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #96 (93f977d) into main (007f4f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   78.50%   78.50%           
=======================================
  Files          53       53           
  Lines        1261     1261           
=======================================
  Hits          990      990           
  Misses        170      170           
  Partials      101      101           
Impacted Files Coverage Δ
internal/server/mi_reporting.go 88.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007f4f8...93f977d. Read the comment docs.

@opg-sonarqube-poc
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition E Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@hawx hawx marked this pull request as ready for review August 2, 2022 07:04
@hawx hawx merged commit 72e3029 into main Aug 2, 2022
@hawx hawx deleted the VEGA-1254-embed-fixes branch August 2, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants