This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Sorting out validations/error messages and copy in uploader steps. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This first PR will implement copy changes and validations and also will add the new DB field `having_problems_uploading_details` used for the appeal flow.
csutter
approved these changes
Feb 2, 2017
| tribunal_case.documents.any? || errors.add(:original_notice_provided, :no_documents) | ||
| end | ||
|
|
||
| def letter_checkboxes |
There was a problem hiding this comment.
documents_uploaded is a verb statement, might be good to have this as one as well so it fits in the validation.
How about letter_checkboxes_ticked?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first PR will implement copy changes and validations and also will add the
new DB field
having_problems_uploading_detailsused for the appeal flow.Another PR will be created for styling and dropzone JS changes.