pcpserver.c: properly fill the opcode field of response

fixes #327
miniupnp · Sep 7, 2018 · 95d707a · 95d707a
1 parent a2baa36
commit 95d707a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/miniupnpd/pcpserver.c b/miniupnpd/pcpserver.c
@@ -1434,7 +1434,7 @@ static int processPCPRequest(void * req, int req_size, pcp_info_t *pcp_msg_info)
 }
 
 
-static void createPCPResponse(unsigned char *response, pcp_info_t *pcp_msg_info)
+static void createPCPResponse(unsigned char *response, const pcp_info_t *pcp_msg_info)
 {
 	response[2] = 0;	/* reserved */
 	memset(response + 12, 0, 12);	/* reserved */
@@ -1445,7 +1445,7 @@ static void createPCPResponse(unsigned char *response, pcp_info_t *pcp_msg_info)
 		response[0] = pcp_msg_info->version;
 	}
 
-	response[1] |= 0x80;	/* r_opcode */
+	response[1] = pcp_msg_info->opcode | 0x80;	/* r_opcode */
 	response[3] = pcp_msg_info->result_code;
 	if(epoch_origin == 0) {
 		epoch_origin = startup_time;