Composer update #238
Merged
Composer update #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merci ! :-) |
|
Note to self: NEVER EVER EVER EVER merge something without reading PR comment entirely. |
|
Buuut. It was broken anyway... :-D So... |
|
yeah, creating the phar was also broken. But anyway, it only breaks things if you try to release a new version. So you only need to wait the composer update before releasing Mink. Btw, we need to do the same in Behat :) |
|
@stof yup, i'll do it myself, mate. |
|
@everzet ok, fixed now, see vendor/autoload.php + vendor/composer/* |
|
@Seldaek merci, mate :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the compilers to use the new location for the composer files.
The change done yesterday started a flamewar on the composer mailing-list so another change will be done soon (probably this weekend) with the agreement found in the discussion. Following @Seldaek's advice, this PR uses the upcoming structure directly to avoid doing 2 updates. But this needs that this PR cannot be merged yet (we need to wait for the composer update).
Additionally, it fixes #235 by adding the optional dependency to PHPUnit in the pear package