Added a test ensuring that new driver methods are added to the CoreDriver #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea. With not only ensures high coverage, but also checks for human errors, that might have been forgotten to add new methods to CoreDriver or did it with wrong method signature. |
stof
added a commit
that referenced
this pull request
Jan 20, 2014
Added a test ensuring that new driver methods are added to the CoreDriver
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is written in a way ensuring that we get a nice failure and not a fatal error (the faster way to ensure the implementation of method would be to instantiate a child class of CoreDriver, but it would not be user-friendly).
I also moved the
@throws UnsupportedDriverActionExceptionto the interface as it is the right place to say that the exception should be thrown when the action is unsupported