Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for setting invalid values for html5 types #78

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

uuf6429
Copy link
Member

@uuf6429 uuf6429 commented Jun 18, 2023

No description provided.

@stof
Copy link
Member

stof commented Jun 19, 2023

Same comment than in #79 about the usage of data providers.

If we want to reduce test duplication, we can use some private methods.

@uuf6429 uuf6429 marked this pull request as draft July 12, 2023 22:20
tests/Form/Html5Test.php Outdated Show resolved Hide resolved
tests/Form/Html5Test.php Outdated Show resolved Hide resolved
@uuf6429 uuf6429 force-pushed the test-invalid-values-for-html5-types branch from 34f00bf to 9409454 Compare July 15, 2023 18:56
@uuf6429 uuf6429 marked this pull request as ready for review July 15, 2023 18:57
@stof stof merged commit 5f8d508 into minkphp:master Sep 26, 2023
2 checks passed
@uuf6429 uuf6429 deleted the test-invalid-values-for-html5-types branch September 26, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants