Remove tests enforcing a DriverException for null values in setValue #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract of the method says that the argument type is `string|bool|array`. Passing null does not respect the contract. So there is no reason for the driver testsuite to expect drivers to throw a DriverException for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract of the method says that the argument type is
string|bool|array. Passing null does not respect the contract. So there is no reason for the driver testsuite to expect drivers to throw a DriverException for this case.This was introduced in #78 and #79.
I caught this when updating BrowserKitDriver to make those new tests pass, when phpstan told me that the value cannot be
nulland so the$value === nullcondition was always false.