Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GeneralTest #79

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Improve GeneralTest #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9984e40
Test setValue on button; improve invalid values test
uuf6429 Jun 18, 2023
fc18bff
CR fixes
uuf6429 Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 40 additions & 87 deletions tests/Form/GeneralTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,93 +262,6 @@ public function testQuoteInValue(): void
}
}

public function testSetArrayValueInTextInput(): void
{
$this->getSession()->visit($this->pathTo('/advanced_form.html'));

$webAssert = $this->getAssertSession();

$firstname = $webAssert->fieldExists('first_name');

$this->expectException(DriverException::class);
$firstname->setValue(['bad']);
}

public function testSetArrayValueInTextarea(): void
{
$this->getSession()->visit($this->pathTo('/advanced_form.html'));

$webAssert = $this->getAssertSession();

$notes = $webAssert->fieldExists('notes');

$this->expectException(DriverException::class);
$notes->setValue(['bad']);
}

public function testSetArrayValueInFileInput(): void
{
$this->getSession()->visit($this->pathTo('/advanced_form.html'));

$webAssert = $this->getAssertSession();

$about = $webAssert->fieldExists('about');

$this->expectException(DriverException::class);
$about->setValue(['bad']);
}

/**
* @dataProvider provideBooleanValues
*/
public function testSetBooleanValueInTextInput(bool $value): void
{
$this->getSession()->visit($this->pathTo('/advanced_form.html'));

$webAssert = $this->getAssertSession();

$firstname = $webAssert->fieldExists('first_name');

$this->expectException(DriverException::class);
$firstname->setValue($value);
}

/**
* @dataProvider provideBooleanValues
*/
public function testSetBooleanValueInTextarea(bool $value): void
{
$this->getSession()->visit($this->pathTo('/advanced_form.html'));

$webAssert = $this->getAssertSession();

$notes = $webAssert->fieldExists('notes');

$this->expectException(DriverException::class);
$notes->setValue($value);
}

/**
* @dataProvider provideBooleanValues
*/
public function testSetBooleanValueInFileInput(bool $value): void
{
$this->getSession()->visit($this->pathTo('/advanced_form.html'));

$webAssert = $this->getAssertSession();

$about = $webAssert->fieldExists('about');

$this->expectException(DriverException::class);
$about->setValue($value);
}

public static function provideBooleanValues(): iterable
{
yield [true];
yield [false];
}

public function testMultiInput(): void
{
$this->getSession()->visit($this->pathTo('/multi_input_form.html'));
Expand Down Expand Up @@ -435,4 +348,44 @@ public function testSubmitEmptyTextarea(): void
$this->assertStringContainsString($searchString, $pageContent);
}
}

/**
* @dataProvider provideInvalidValues
*
* @param mixed $value
*/
public function testSetInvalidValueInField(string $field, $value): void
{
$this->getSession()->visit($this->pathTo('/advanced_form.html'));

$webAssert = $this->getAssertSession();

$color = $webAssert->elementExists('named', array('id_or_name', $field));

$this->expectException(DriverException::class);
$color->setValue($value);
}

public static function provideInvalidValues(): iterable
{
$nullValue = ['null', null];
$trueValue = ['true', true];
$falseValue = ['false', false];
$arrayValue = ['array', ['bad']];
$stringValue = ['string', 'updated'];

$scenarios = [
// field type, name or id, list of values to check
['file', 'about', [$nullValue, $trueValue, $falseValue, $arrayValue]],
['textarea', 'notes', [$nullValue, $trueValue, $falseValue, $arrayValue]],
['text', 'first_name', [$nullValue, $trueValue, $falseValue, $arrayValue]],
['button', 'submit', [$nullValue, $trueValue, $falseValue, $arrayValue, $stringValue]],
];

foreach ($scenarios as [$fieldType, $fieldNameOrId, $values]) {
foreach ($values as [$valueDesc, $actualValue]) {
yield "$fieldType field with $valueDesc" => [$fieldNameOrId, $actualValue];
}
}
}
}