Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception, when options are changed on running server #157

Closed
aik099 opened this issue Mar 4, 2016 · 3 comments
Closed

Throw exception, when options are changed on running server #157

aik099 opened this issue Mar 4, 2016 · 3 comments

Comments

@aik099
Copy link
Member

aik099 commented Mar 4, 2016

The Behat\Mink\Driver\NodeJS\Server class have bunch of methods for setting options of the NodeJS server, that will be created. There is only one problem with them: when used on already running server they:

  • have no effect
  • developer thinks all worked fine

Proposing to throw an exception, when attempt to change running server options is made.
This was referenced Mar 4, 2016
Closed
Closed
@stof
Copy link
Member

stof commented Mar 4, 2016

looks good to me

@aik099
Copy link
Member Author

aik099 commented Mar 4, 2016

Nice, will send a PR soon. Please look on other issues I've reported for Zombie.

@aik099 aik099 mentioned this issue Jun 17, 2016
Merged
@aik099
Copy link
Member Author

aik099 commented Jun 17, 2016

PR created, ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @aik099