Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing host or port should regenerate server code #158

Closed
aik099 opened this issue Mar 4, 2016 · 2 comments
Closed

Changing host or port should regenerate server code #158

aik099 opened this issue Mar 4, 2016 · 2 comments

Comments

@aik099
Copy link
Member

aik099 commented Mar 4, 2016

The Behat\Mink\Driver\NodeJS\Server::createTemporaryServer uses following options of the server:

  • host
  • port
  • nodeModulesPath

Currently on change of nodeModulesPath causes temporary server code to be regenerated.

Propose to regenerate temporary server code also on host and port option change.

Separate issue (see #157) is created to prevent calling these methods on already running server, that would have no effect.

@stof
Copy link
Member

stof commented Mar 4, 2016

See #161 for my proposal to solve it in a much better way (the case of a running server still need to be prevented even in my proposal)

@aik099
Copy link
Member Author

aik099 commented Mar 4, 2016

Agreed that creating ENV-based server instead of PHP variable patching is better way.

@aik099 aik099 closed this as completed Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants