Skip to content

Commit

Permalink
filter out "docker" distributions from configuration (#277)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mintty
mintty committed Apr 7, 2021
1 parent a332cf8 commit ee4e403
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions config-distros.sh
View file
Expand Up @@ -291,6 +291,11 @@ config () {
echoc "- root $root"
wdir=%USERPROFILE%

case "$name" in
docker*) echo skipping docker system

This comment has been minimized.

Sign in to view

Copy link
@hhromic

hhromic Apr 9, 2021

Hello, thanks for this. But wouldn't it be safer to use docker-* instead?
I know is unlikely but just in case someone renames a distro to something that starts with docker alone.
return;;
esac

if $ok && ! $remove && [ -n "$distro" ]
then # fix #163: backend missing +x with certain mount options
echo Setting +x wslbridge2 backends for distro "'$distro'"
Expand Down

3 comments on commit ee4e403

@mintty
Copy link
Owner Author

@mintty mintty commented on ee4e403 Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A future version could be named docker2-something, and checking the name is a hack anyway, see #261 (comment) for an anticipated better solution.

@hhromic
Copy link

@hhromic hhromic commented on ee4e403 Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that seems like a much better solution indeed. Thanks for replying! And thanks for this really nice terminal.

@mintty
Copy link
Owner Author

@mintty mintty commented on ee4e403 Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems like a much better solution

But is wasn't yet implemented at the time of that comment and I do not monitor that stuff. So someone will have to notify and perhaps even provide details when it becomes available.

Please sign in to comment.