Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip docker* DistributionName? #277

Closed
puellanivis opened this issue Mar 29, 2021 · 7 comments
Closed

Skip docker* DistributionName? #277

puellanivis opened this issue Mar 29, 2021 · 7 comments

Comments

@puellanivis
Copy link

I just spent a bunch of time looking into how to get the config-distros.sh file to ignore the docker distros. There’s pretty much zero reason I would ever really want to start up in those WSL distros, they’re just there to provide docker. Docker itself allows for integrating with other WSL distros as well, so my openSUSE WSL distro can access my docker instance just as well as anything else.

I eventually hacked something together to get only the context menus that I want, and I just manually deleted the unwanted Start Menu entries. Seems like a bit of a pain that could be avoided by just skipping over anything docker*) in the config()` case statement?

@mintty
Copy link
Owner

mintty commented Mar 30, 2021

Duplicate; I postponed it following #261 (comment),;
also I don't have docker installed myself so I'm somehow missing a test case.
Is it easy to tell a docker distro apart? Do their names all start with "docker"?

@puellanivis
Copy link
Author

puellanivis commented Mar 30, 2021

Ah, I went looking for another issue covering it, but didn’t think to look in that one.

Yes, it is reasonably easy to tell them apart as the DistributionName for the two are docker-desktop and docker-desktop-data.

PS: They also have a BasePath value of: \\?\C:\Users\${USERNAME}\AppData\Local\Docker\wsl\distro

@mintty
Copy link
Owner

mintty commented Apr 7, 2021

I've uploaded a filtering version of the configuration script, for the next release. Feel free to download and test it.
The script also takes a parameter -info for some checking.
This patch does not catch the case (described in another issue) that a docker system gets setup as WSL default distribution.

@puellanivis
Copy link
Author

Makes sense. Skipping the WSL default would be way harder.

@mintty
Copy link
Owner

mintty commented Apr 9, 2021

PS: They also have a BasePath value of: \?\C:\Users${USERNAME}\AppData\Local\Docker\wsl\distro

Now also filtering out a docker default distribution based on this information, easy enough.

@mintty
Copy link
Owner

mintty commented Apr 15, 2021

Released 3.5.0.

@mintty mintty closed this as completed Apr 15, 2021
@puellanivis
Copy link
Author

Works amazing. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants