Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task_id as a query parameter to the GET /origins endpoint #1414

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

Donnype
Copy link
Contributor

@Donnype Donnype commented Jul 18, 2023

Changes

Origins could only be fetched through passing a reference that should be in the result set. Now you can also pass the task_id instead (which is in fact the normalizer_meta id). Also the repository interface is now more generic by having a list() method that accepts several query parameters that you can combine instead of defining a method per query type, just like many other of our repositories. These new parameters are passed to the API and connector as well.

Issue link

Closes #1411

Proof

See tests.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Donnype Donnype marked this pull request as ready for review July 18, 2023 13:03
@Donnype Donnype requested a review from a team as a code owner July 18, 2023 13:03
@Donnype Donnype added rocky Issues related to Rocky octopoes Issues related to octopoes chore xtdb labels Jul 18, 2023
@Donnype Donnype self-assigned this Jul 18, 2023
@Donnype Donnype changed the title Add task_id as query parameter to the GET /origin endpoint Add task_id as a query parameter to the GET /origins endpoint Jul 18, 2023
@Darwinkel
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

  • No apparent regressions

@dekkers dekkers merged commit 26145ce into main Jul 19, 2023
35 checks passed
@dekkers dekkers deleted the feature/filter-origins-on-task-id branch July 19, 2023 12:16
jpbruinsslot added a commit that referenced this pull request Jul 24, 2023
* main:
  Fix robot test (#1420)
  Use the correct clearance level variable in organization member list template (#1427)
  Fix translation in Debian package (#1432)
  Reschedule tasks when no results in bytes are found after grace period (#1410)
  Don't scan hostname nmap in nmap boefje (#1415)
  Add and use our own CVE API (#1383)
  Add `task_id` as a query parameter to the `GET /origins` endpoint (#1414)
  Remove member group checks and check for permission instead (#1275)
  Bump cryptography from 41.0.0 to 41.0.2 in /boefjes/boefjes/plugins/kat_ssl_certificates (#1396)
  Bump cryptography from 41.0.1 to 41.0.2 in /bytes (#1397)
  Build the Debian build image on the main branch (#1387)
  Add explicit `black` config to all modules (#1395)
  Fix <no title> in the user guide docs (#1391)
  Add configurable octpoes request timeout (#1382)
  Remove hardcoded clearance level in member list for superusers (#1390)
  Add Debian build depends for CVE API package (#1384)
  Add buttons to manual rerun tasks, both boefjes or normalizers (#1339)
  Use fix multiprocessing bug on macOS where `qsize()` is not implemented (#1374)
jpbruinsslot added a commit that referenced this pull request Jul 25, 2023
* main: (95 commits)
  Translations for release 1.11 - EN -> NL, PAP (#1439)
  Add Question ooi model and create the first bit that generates a question (#1407)
  make port classification configurable (#1418)
  KATalogus API filtering and pagination (#1405)
  Fix robot test (#1420)
  Use the correct clearance level variable in organization member list template (#1427)
  Fix translation in Debian package (#1432)
  Reschedule tasks when no results in bytes are found after grace period (#1410)
  Don't scan hostname nmap in nmap boefje (#1415)
  Add and use our own CVE API (#1383)
  Add `task_id` as a query parameter to the `GET /origins` endpoint (#1414)
  Remove member group checks and check for permission instead (#1275)
  Bump cryptography from 41.0.0 to 41.0.2 in /boefjes/boefjes/plugins/kat_ssl_certificates (#1396)
  Bump cryptography from 41.0.1 to 41.0.2 in /bytes (#1397)
  Build the Debian build image on the main branch (#1387)
  Add explicit `black` config to all modules (#1395)
  Fix <no title> in the user guide docs (#1391)
  Add configurable octpoes request timeout (#1382)
  Remove hardcoded clearance level in member list for superusers (#1390)
  Add Debian build depends for CVE API package (#1384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore octopoes Issues related to octopoes rocky Issues related to Rocky xtdb
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consider refactoring GET /origins endpoint and especially origin_repository.list_by_{} to have 1 method
4 participants