Fix robot test #1420
Merged
Fix robot test #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Donnype
reviewed
Jul 19, 2023
Makefile
Outdated
| @@ -112,3 +112,9 @@ poetry-dependencies: | |||
| # NOTE: pip does not yet support hash verification for git dependencies; | |||
| # rocky's requirements-dev.txt unfortunately has no hashing until then | |||
| sed -i '/--hash/d; s/ \\$$//' rocky/requirements-dev.txt | |||
|
|
|||
|
|
|||
| local-ci-robot: | |||
There was a problem hiding this comment.
Isn't this supposed to work?
$ cd rocky
$ make test-rfIt is not working for me I see so I suppose it hasn't been updated. I'd say we should remove that target (and test-prepare) and perhaps call this new make target in the github workflow?
There was a problem hiding this comment.
I actually wanted this just to run the onboarding in ci , one part flow of the QA which I had to do it manually. The make test-rf is running all and for me it fails as well.
There was a problem hiding this comment.
I have removed it till we find a better solution in another PR
praseodym
reviewed
Jul 19, 2023
Makefile
Outdated
|
|
||
| local-ci-robot: | ||
| make reset | ||
| docker exec -it nl-kat-coordination-rocky-1 /bin/bash -c 'export DJANGO_SUPERUSER_PASSWORD=robotpassword && python manage.py createsuperuser --full_name robot --email robot@localhost --noinput' |
There was a problem hiding this comment.
This should use docker-compose run --rm rocky so that it works in every environment and doesn't reuse the existing container.
There was a problem hiding this comment.
I have removed this part as this was an extra for this PR
ammar92
approved these changes
Jul 20, 2023
Darwinkel
approved these changes
Jul 20, 2023
dekkers
approved these changes
Jul 24, 2023
jpbruinsslot
added a commit
that referenced
this pull request
Jul 24, 2023
* main: Fix robot test (#1420) Use the correct clearance level variable in organization member list template (#1427) Fix translation in Debian package (#1432) Reschedule tasks when no results in bytes are found after grace period (#1410) Don't scan hostname nmap in nmap boefje (#1415) Add and use our own CVE API (#1383) Add `task_id` as a query parameter to the `GET /origins` endpoint (#1414) Remove member group checks and check for permission instead (#1275) Bump cryptography from 41.0.0 to 41.0.2 in /boefjes/boefjes/plugins/kat_ssl_certificates (#1396) Bump cryptography from 41.0.1 to 41.0.2 in /bytes (#1397) Build the Debian build image on the main branch (#1387) Add explicit `black` config to all modules (#1395) Fix <no title> in the user guide docs (#1391) Add configurable octpoes request timeout (#1382) Remove hardcoded clearance level in member list for superusers (#1390) Add Debian build depends for CVE API package (#1384) Add buttons to manual rerun tasks, both boefjes or normalizers (#1339) Use fix multiprocessing bug on macOS where `qsize()` is not implemented (#1374)
jpbruinsslot
added a commit
that referenced
this pull request
Jul 25, 2023
* main: (95 commits) Translations for release 1.11 - EN -> NL, PAP (#1439) Add Question ooi model and create the first bit that generates a question (#1407) make port classification configurable (#1418) KATalogus API filtering and pagination (#1405) Fix robot test (#1420) Use the correct clearance level variable in organization member list template (#1427) Fix translation in Debian package (#1432) Reschedule tasks when no results in bytes are found after grace period (#1410) Don't scan hostname nmap in nmap boefje (#1415) Add and use our own CVE API (#1383) Add `task_id` as a query parameter to the `GET /origins` endpoint (#1414) Remove member group checks and check for permission instead (#1275) Bump cryptography from 41.0.0 to 41.0.2 in /boefjes/boefjes/plugins/kat_ssl_certificates (#1396) Bump cryptography from 41.0.1 to 41.0.2 in /bytes (#1397) Build the Debian build image on the main branch (#1387) Add explicit `black` config to all modules (#1395) Fix <no title> in the user guide docs (#1391) Add configurable octpoes request timeout (#1382) Remove hardcoded clearance level in member list for superusers (#1390) Add Debian build depends for CVE API package (#1384) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix for broken ci robot test
make local-ci-robotto automate the process of onboarding, can be used for QA as well @Darwinkel