Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not emitting empty items in string-array #64

Closed
brentinrochester opened this issue Dec 5, 2019 · 1 comment
Closed

Not emitting empty items in string-array #64

brentinrochester opened this issue Dec 5, 2019 · 1 comment

Comments

@brentinrochester
Copy link

brentinrochester commented Dec 5, 2019

It is valid for an item in a string-array to be empty. The parser will accept a self-closing tag, but it is more common to find:
<item></item>

This is commonly used. You can see an example from AOSP source that uses this technique multiple times.

However, a2po will omit those with a warning. Then the string-array is missing an item. If run on the case in the provided example, this causes the remaining values to correlate with the wrong array index, and thus the wrong status is displayed.

It is critical that empty items be emitted in the original location within a string-array.

@miracle2k
Copy link
Owner

So I think this was fixed in #64, yes? Closing it then. Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants