Now emits empty item tags within a string-array #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentinrochester
force-pushed
the
bug64
branch
from
8894b46
to
49081bc
Compare
It is acceptable for a string-array to contain <item></item> or <item/> These empty items may be placeholders to allow enumerations to align with status strings. Omitting the empty items causes any subsequent items to correspond to the wrong index. Changed so empty items are emitted in the original location. Bug:64
brentinrochester
force-pushed
the
bug64
branch
from
49081bc
to
3b0cef6
Compare
miracle2k
added a commit
that referenced
this pull request
Dec 14, 2019
Now emits empty item tags within a string-array
|
I had to revert this PR unfortunately. See the test failure here (https://travis-ci.org/miracle2k/android2po/jobs/625102788) There are two - Travis only shows the first. Fundamentally, this seems complicated by the fact that Babel itself does not write empty strings to the po catalog file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is acceptable for a string-array to contain
<item></item>
or
<item/>
These empty items may be placeholders to allow enumerations to
align with status strings. Omitting the empty items causes any
subsequent items to correspond to the wrong index.
Changed so empty items are emitted in the original location.
Bug:64