set process in jade filter every setup() #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per https://github.com/miracle2k/webassets/blob/master/src/webassets/filter/__init__.py#L246: def setup(self): ... "Note: This may be called multiple times if one filter instance is used with different asset environment instances." ... If setup is called multiple times, this change means the Jade Filter object will have the same arguments to run every time.
miracle2k
added a commit
that referenced
this pull request
Apr 18, 2016
… jade filter every setup()"
|
Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per https://github.com/miracle2k/webassets/blob/master/src/webassets/filter/__init__.py#L246:
If setup is called multiple times, this change means the Jade Filter object will have the same arguments to run every time.