Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: assert the presence of the yt-dlp dep #670

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

miraclx
Copy link
Owner

@miraclx miraclx commented Apr 11, 2024

Add a test to ensure the yt-dlp binary is present after install has been run.

Found out why CI was failing, over-dependence on caches. Looks like 2 months ago, we cached an image that didn't appropriately download the yt-dlp subdependency of youtube-dl-exec and we kept reusing that image since freyr didn't change in this period of time.

Had to evict caches, and now it works! - miraclx/freyr-js/actions/runs/8623905754/job/23690297872

Originally posted by @miraclx in #669 (comment)

Linked: microlinkhq/youtube-dl-exec#190

Copy link

github-actions bot commented Apr 11, 2024


🐋 🤖

A docker image for this PR has been built!

docker pull freyrcli/freyrjs-git:pr-670
Base (master)
This Patch


What's this?

This docker image is a self-contained sandbox that includes all the patches made in this PR. Allowing others to easily use your patches without waiting for it to get merged and released officially.

For more context, see https://github.com/miraclx/freyr-js#docker-development.

@miraclx miraclx merged commit 456bca8 into master Apr 11, 2024
22 checks passed
@miraclx miraclx deleted the miraclx/assert-has-ytdlp branch April 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant