Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two almost-identical modules in the repository:
The first of these has fallen into disrepair; for example, it includes the
external
declaration:which no longer matches the signature of
caml_alloc_pages
, which now has two arguments.A related problem is that the C code forcaml_alloc_pages
is built as part of the "unix
" library (io-page.unix
), but used in the "lib
" library (io-page
).This PR removes the obsolete
unix/io_page.ml
moduleand moves the C code for.caml_alloc_pages
into theio-page
library